1824819 - remove obsolete changes remaining in moz-libwebrtc 'Rollup of local modifications'

Status: RESOLVED FIXED

(Core :: WebRTC, task, P2)

Description

[Michael Froman [:mjf]]

Researching a patch in moz-libwebrtc "Bug 1376873 - Rollup of local modifications", I find a set of changes we introduced that are no longer needed either because they are no longer referenced in other code or because they were gratuitous edits.

From here

api/video_codecs/video_codec.h
appears unused
+double scaleDownBy
+uint8_t packetizationMode


common_video/h264/h264_common.h
appears unused
+enum SeiType


modules/audio_processing/include/audio_processing.h
appears unused
adds kSampleRate44_1kHz = 44100


modules/desktop_capture/desktop_capturer.h
adds - appears unused
+  // Creates a platform specific DesktopCapturer instance which targets to
+  // capture apps.
+  static std::unique_ptr<DesktopCapturer> CreateRawAppCapturer(
+  	const DesktopCaptureOptions& options);


modules/desktop_capture/win/screen_capturer_win_gdi.cc
unnecesary indent change:
-      	GetProcAddress(dwmapi_library_, "DwmEnableComposition"));
+    	GetProcAddress(dwmapi_library_, "DwmEnableComposition"));


modules/rtp_rtcp/source/rtp_rtcp_config.h
appears unused
+
+enum { RTCP_NUMBER_OF_SR = 60 };
+


modules/rtp_rtcp/source/rtp_sender.h
appears unused
+  int32_t SetRID(const char* rid);
+  int32_t SetMId(const char* mid);
+


modules/video_capture/video_capture_defines.h
appears unused
adds VideoCaptureDataCallback


modules/video_capture/windows/video_capture_factory_windows.cc
unnecesary edit
-rtc::scoped_refptr<VideoCaptureModule> VideoCaptureImpl::Create(
-	const char* device_id) {
+rtc::scoped_refptr<VideoCaptureModule> VideoCaptureImpl::Create(const char* device_id) {


system_wrappers/source/cpu_features.cc
unnecessary added blank line


modules/video_coding/jitter_buffer.h
adds - appears unused
+  VCMFrameBuffer* FindFrame(uint16_t seq_num, uint32_t timestamp);


modules/video_coding/jitter_buffer_common.h
kBufferSafetyMargin appears unused
-  kMaxJBFrameSizeBytes = 4000000	// sanity don't go above 4Mbyte.
+  kMaxJBFrameSizeBytes        	= 4000000, // sanity don't go above 4Mbyte.
+  kBufferSafetyMargin         	= 100  	// enough for ~50 NALs in a STAP-A


modules/desktop_capture/mock_desktop_capturer_callback.h
unnecessary - we don't build mock_desktop_capturer_callback
adds
-                   	std::unique_ptr<DesktopFrame> frame) final;
+                   	std::unique_ptr<DesktopFrame> frame) final override;

Comment 1

[Michael Froman [:mjf]]

First round of changes: https://treeherder.mozilla.org/jobs?repo=try&revision=11f0c0f801f081b309de4e1eef160000063b52fe

Comment 2

[Michael Froman [:mjf]]

Round 2: https://treeherder.mozilla.org/jobs?repo=try&revision=a9e0f1e1a14fe7a351974783a1fe8c0f4b8fdd58
Round 3/4: https://treeherder.mozilla.org/jobs?repo=try&revision=ba2e0ff95e5271fce52628e0b543043be0562f06

Comment 3

[Michael Froman [:mjf]]

Round 5/6: https://treeherder.mozilla.org/jobs?repo=try&revision=01603fda3af3ae13bd3052268f1b854fad2efad5

Comment 4

[Michael Froman [:mjf]]

Round 7: https://treeherder.mozilla.org/jobs?repo=try&revision=d5ebc9a276e43ad096b8d3c0ac54f1d4e5406d8b

Comment 5

[Michael Froman [:mjf]]

Round 8: https://treeherder.mozilla.org/jobs?repo=try&revision=a12fa2edd8af34d2b13bef8a7f47bf2e409e238c

Comment 6

[Michael Froman [:mjf]]

Round 9: https://treeherder.mozilla.org/jobs?repo=try&revision=bd7cae1f6b10e05bc95518e79e58fd56d1ad0219

Comment 7

[Michael Froman [:mjf]]

Round 10/11: https://treeherder.mozilla.org/jobs?repo=try&revision=df6c6a733403661724a521a9677d052cad882f20

Comment 8

[Michael Froman [:mjf]]

Round 12: https://treeherder.mozilla.org/jobs?repo=try&revision=66e90af3f197298c3a40cbecc27ef7e3eac8a11b

Comment 9

[Michael Froman [:mjf]]

Round 13: https://treeherder.mozilla.org/jobs?repo=try&revision=5c9cb3b2f13ebd3aaad713a2e491356fa958fd6a

Comment 10

[Michael Froman [:mjf]]

Attachment: Bug 1824819 - pt1 - removing obsolete changes from libwebrtc r?dbaker!

These were changes we've been carrying in our github patch stack
labeled "Bug 1376873 - Rollup of local modifications" that have
been verified as unused or abandoned.

Comment 11

[Michael Froman [:mjf]]

Attachment: Bug 1824819 - pt2 - un-rename audio_send_stream_call.cc to audio_send_stream.cc r?dbaker!

Depends on D174686

Comment 12

[Michael Froman [:mjf]]

Attachment: Bug 1824819 - pt3 - moz.build updates r?dbaker!

Depends on D174687

Comment 13

[Michael Froman [:mjf]]

Attachment: Bug 1824819 - pt4 - remove abandoned files no longer appearing in upstream r?dbaker!

Depends on D174688

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f9a9690a5b3d
pt1 - removing obsolete changes from libwebrtc r=dbaker,webrtc-reviewers
https://hg.mozilla.org/integration/autoland/rev/17c47319b63e
pt2 - un-rename audio_send_stream_call.cc to audio_send_stream.cc r=dbaker,webrtc-reviewers
https://hg.mozilla.org/integration/autoland/rev/ba63b602e7e0
pt3 - moz.build updates r=dbaker,ng,webrtc-reviewers
https://hg.mozilla.org/integration/autoland/rev/3a0e52e2e5f9
pt4 - remove abandoned files no longer appearing in upstream r=dbaker,webrtc-reviewers

Comment 15

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/f9a9690a5b3d
https://hg.mozilla.org/mozilla-central/rev/17c47319b63e
https://hg.mozilla.org/mozilla-central/rev/ba63b602e7e0
https://hg.mozilla.org/mozilla-central/rev/3a0e52e2e5f9