Closed Bug 1824819 Opened 2 years ago Closed 2 years ago

remove obsolete changes remaining in moz-libwebrtc 'Rollup of local modifications'

Categories

(Core :: WebRTC, task, P2)

task

Tracking

()

RESOLVED FIXED
114 Branch
Tracking Status
firefox114 --- fixed

People

(Reporter: mjf, Assigned: mjf)

References

Details

Attachments

(4 files)

Researching a patch in moz-libwebrtc "Bug 1376873 - Rollup of local modifications", I find a set of changes we introduced that are no longer needed either because they are no longer referenced in other code or because they were gratuitous edits.

From here

api/video_codecs/video_codec.h
appears unused
+double scaleDownBy
+uint8_t packetizationMode


common_video/h264/h264_common.h
appears unused
+enum SeiType


modules/audio_processing/include/audio_processing.h
appears unused
adds kSampleRate44_1kHz = 44100


modules/desktop_capture/desktop_capturer.h
adds - appears unused
+  // Creates a platform specific DesktopCapturer instance which targets to
+  // capture apps.
+  static std::unique_ptr<DesktopCapturer> CreateRawAppCapturer(
+  	const DesktopCaptureOptions& options);


modules/desktop_capture/win/screen_capturer_win_gdi.cc
unnecesary indent change:
-      	GetProcAddress(dwmapi_library_, "DwmEnableComposition"));
+    	GetProcAddress(dwmapi_library_, "DwmEnableComposition"));


modules/rtp_rtcp/source/rtp_rtcp_config.h
appears unused
+
+enum { RTCP_NUMBER_OF_SR = 60 };
+


modules/rtp_rtcp/source/rtp_sender.h
appears unused
+  int32_t SetRID(const char* rid);
+  int32_t SetMId(const char* mid);
+


modules/video_capture/video_capture_defines.h
appears unused
adds VideoCaptureDataCallback


modules/video_capture/windows/video_capture_factory_windows.cc
unnecesary edit
-rtc::scoped_refptr<VideoCaptureModule> VideoCaptureImpl::Create(
-	const char* device_id) {
+rtc::scoped_refptr<VideoCaptureModule> VideoCaptureImpl::Create(const char* device_id) {


system_wrappers/source/cpu_features.cc
unnecessary added blank line


modules/video_coding/jitter_buffer.h
adds - appears unused
+  VCMFrameBuffer* FindFrame(uint16_t seq_num, uint32_t timestamp);


modules/video_coding/jitter_buffer_common.h
kBufferSafetyMargin appears unused
-  kMaxJBFrameSizeBytes = 4000000	// sanity don't go above 4Mbyte.
+  kMaxJBFrameSizeBytes        	= 4000000, // sanity don't go above 4Mbyte.
+  kBufferSafetyMargin         	= 100  	// enough for ~50 NALs in a STAP-A


modules/desktop_capture/mock_desktop_capturer_callback.h
unnecessary - we don't build mock_desktop_capturer_callback
adds
-                   	std::unique_ptr<DesktopFrame> frame) final;
+                   	std::unique_ptr<DesktopFrame> frame) final override;
Assignee: nobody → mfroman
Severity: -- → S3
Priority: -- → P2

These were changes we've been carrying in our github patch stack
labeled "Bug 1376873 - Rollup of local modifications" that have
been verified as unused or abandoned.

Depends on D174687

Depends on: 1822194
Pushed by mfroman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f9a9690a5b3d pt1 - removing obsolete changes from libwebrtc r=dbaker,webrtc-reviewers https://hg.mozilla.org/integration/autoland/rev/17c47319b63e pt2 - un-rename audio_send_stream_call.cc to audio_send_stream.cc r=dbaker,webrtc-reviewers https://hg.mozilla.org/integration/autoland/rev/ba63b602e7e0 pt3 - moz.build updates r=dbaker,ng,webrtc-reviewers https://hg.mozilla.org/integration/autoland/rev/3a0e52e2e5f9 pt4 - remove abandoned files no longer appearing in upstream r=dbaker,webrtc-reviewers
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: