1824826 - Implement a view of history in Firefox View

Status: RESOLVED FIXED

(Firefox :: Firefox View, enhancement)

Description

[Mike Kaply [:mkaply]]

Attachment: Initial history design

This bug is for the initial implementation of history in Firefox View.

Once we have the modules and the reusable component, we will implement a very basic view of history.

See the attached design.

In this ticket, we will only show history, and have the two sorting options. Will not have search.

Full spec is available in:

https://www.figma.com/file/wP9MY9KJn9xqPf140lTvTv/Fx-View-Specs-2023?node-id=1951-21529&t=ycyzAaukQlfjnM8F-0

Sub tickets might need to be created as we work on this.

Comment 1

[Jonathan Sudiaman [:jsudiaman]]

FYI: Presumably, this view will use the async API introduced in Bug 1816137. The whitelist entry in browser_all_files_referenced.js should be removed in this case.

Comment 2

[Sarah Clements [:sclements]]

Katie's revisiting the three-dot/more and possiblity the context menus so let's implement that in bug 1833673 (and also to reduce scope on this one).

Comment 3

[Kelly Cochrane [:kcochrane]]

Attachment: Bug 1824826 - Implement view of History and sticky header/navigation in next iteration of Firefox View r=mkaply

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a4e3a2f3ce1b
Implement view of History and sticky header/navigation in next iteration of Firefox View r=mkaply,fluent-reviewers,desktop-theme-reviewers,fxview-reviewers,flod,sfoster

Comment 5

[Iulian Moraru]

Backed out for causing bc failures on browser_all_files_referenced.js.

• Push with failures

• Failure log

Also please take a look at this TV failures before relanding this:

• TEST-UNEXPECTED-FAIL | browser/components/firefoxview/tests/chrome/test_history.html | undefined - timed out after 50 tries. - Should not throw any errors

• TEST-UNEXPECTED-FAIL | browser/components/firefoxview/tests/chrome/test_history.html | The first card has a header for 'Today'.

• Backout link

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/33c08027f6aa
Implement view of History and sticky header/navigation in next iteration of Firefox View r=mkaply,fluent-reviewers,desktop-theme-reviewers,fxview-reviewers,flod,sfoster

Comment 7

[Serban Stanca [:SerbanS]]

Backed out for causing mochitests failures in test_history.html.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/firefoxview/tests/chrome/test_history.html | undefined - timed out after 50 tries. - Should not throw any errors

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/23268d9fcefd
Implement view of History and sticky header/navigation in next iteration of Firefox View r=mkaply,fluent-reviewers,desktop-theme-reviewers,fxview-reviewers,flod,sfoster

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/23268d9fcefd

Comment 10

[Sam Foster [:sfoster] (he/him)]

Clearing need-info. I'm not sure why I was flagged rather than :kcochrane who authored the patch.