1824846 - Improve GMP diagnostics when attempting to first load plugin

Status: RESOLVED FIXED

(Core :: Audio/Video: GMP, task, P3)

Description

[Andrew Osmond [:aosmond] (he/him)]

We have a bunch of crashes on the GMPChild::RecvStartPlugin path. It would be good to break these out to understand why the process is failing to sanitize the plugin path.

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1824846 - Improve GMP diagnostics when attempting to first load plugin.

We are currently seeing crashes in GMPChild::RecvStartPlugin because we
fail to sanitize the plugin path in some way. This patch will make
nightly crash slightly sooner than before so that we can understand why
the sanitization is actually failing.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/27a68283e532
Improve GMP diagnostics when attempting to first load plugin. r=media-playback-reviewers,azebrowski

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/27a68283e532

Comment 4

[[:fabrice] Fabrice Desré]

Nit: https://hg.mozilla.org/mozilla-central/rev/27a68283e532be19f1db26fcdb55d5a98b2f7be0#l1.136 should be GMP_DIAGNOSTIC_CRASH

Comment 5

[Bernard Alleysson]

(In reply to [:fabrice] Fabrice Desré from comment #4)

Nit: https://hg.mozilla.org/mozilla-central/rev/27a68283e532be19f1db26fcdb55d5a98b2f7be0#l1.136 should be GMP_DIAGNOSTIC_CRASH

You're right. Builds using "ac_add_options --as-milestone=release" in mozconfig fail because of this.