1824910 - Display inconsistency of folder & file

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[erosman [:erosman]]

Attachment: sourceURL1.png

As per attached screenshots, Dev Tools displays files as decoded but folders as encoded.

Example:

//# sourceURL=moz-extension://f5dc...3411/userscript/IMDb%20Scout%20Mod/IMDb%20Scout%20Mod.user.js

There is also a consideration with displaying http/s URLs as a sub folder of https:/.

Example:

//# sourceURL=moz-extension://f5dc...3411/userscript/IMDb%20Scout%20Mod/https://code.jquery.com/jquery-3.5.1.min.js

- Ubuntu 22.10 Wayland, Nightly 113.0a1 (2023-03-27) (64-bit)

Comment 1

[erosman [:erosman]]

Attachment: sourceURL2.png

Note https:/ folder

Comment 2

[erosman [:erosman]]

Attachment: sourceURL3.png

Note https:/ folder

Comment 3

[erosman [:erosman]]

Attachment: sourceURL4.png

Another example with Unicode characters

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

The issue for non-decoded folder can be visible in https://firefox-devtools-debugger-sources-tree.glitch.me/
The issue for folder containing urls is different, we should probably have a dedicated bug for it

Comment 5

[erosman [:erosman]]

The issue for folder containing urls is different, we should probably have a dedicated bug for it

Split to bug 1829460

Comment 6

[erosman [:erosman]]

The issue for non-decoded folder can be visible in https://firefox-devtools-debugger-sources-tree.glitch.me/

Updated the title as it is not limited to sourceURL

Comment 7

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1829100 - [devtools] Decode folder name in Debugger Sources Tree. r=#devtools-reviewers.

We were decoding groups and files source items label,
but not folders.
We fix this and take the occasion to use decodeURI instead
of the non-standard unescape.
A test is added to ensure the source tree items are rendered
as expected.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e9234a427470
Bug 1829100 - [devtools] Decode folder name in Debugger Sources Tree. r=devtools-reviewers,bomsy.

Comment 9

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/e9234a427470

Comment 10

[erosman [:erosman]]

I have also noticed that the code changes the scheme to Lowercase. e.g.

//# sourceURL=FireMonkey://UserScript/....

// --- or

//# sourceURL=FireMonkey:UserScript/....

will be shown as

firemonkey://
 -- UserScript/....

While it is understandable in case of real schemes (http/https/...), they are not the only possibility.

Comment 11

[erosman [:erosman]]

Attachment: sourceURL5.png

sourceURL scheme changed to lowercase

Comment 12

[erosman [:erosman]]

The scheme issue will be moved to Bug 1829460 .

Comment 13

[erosman [:erosman]]

Confirmed fixed in Nightly 114.0a1 (2023-04-25) (64-bit)
Build ID 20230425154313
Ubuntu 23.04