1824948 - Remove about:firefoxview link from about:welcome's last "slide"

Status: VERIFIED FIXED

(Firefox :: Messaging System, task, P1)

Description

[Sarah Clements [:sclements]]

This was leftover from 106 colorways promotion and should be removed. We do not want to be promoting Firefox View right now until we can add additional value. Please remove asap.

Comment 1

[Ed Lee :Mardak]

[Tracking Requested - why for this release]: A leftover button is shown directing new users to Firefox View requested to be removed ASAP.

Comment 2

[Ed Lee :Mardak]

Should the secondary button for "Start browsing" become the blue primary button replacing "See what's new" or kept in the corner and gray?

https://searchfox.org/mozilla-central/rev/42747dfd314e4c939dc7c33a13e1a2fddf4926fc/browser/components/newtab/aboutwelcome/lib/AboutWelcomeDefaults.jsm#365-376

Comment 3

[Gabrielle Lussier [:glussier]]

(In reply to Ed Lee :Mardak from comment #2)

Should the secondary button for "Start browsing" become the blue primary button replacing "See what's new" or kept in the corner and gray?

https://searchfox.org/mozilla-central/rev/42747dfd314e4c939dc7c33a13e1a2fddf4926fc/browser/components/newtab/aboutwelcome/lib/AboutWelcomeDefaults.jsm#365-376

Let's remove the secondary button from the bottom right corner and use a primary button instead that says "Start browsing." I'll attach a screenshot.

Comment 4

[Gabrielle Lussier [:glussier]]

Attachment: gratitudeScreen

New "gratitude" screen

Comment 5

[Emily McMinn :emcminn]

Attachment: Bug 1824948 - Remove about:firefoxview link from Gratitude screen

Comment 6

[Dianna Smith [:diannaS]]

As a reminder the last beta is tomorrow, this should land and request uplift before that.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/99e511f56905
Remove about:firefoxview link from Gratitude screen r=pdahiya,omc-reviewers

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/99e511f56905

Comment 9

[Emily McMinn :emcminn]

Comment on attachment 9325812 [details]
Bug 1824948 - Remove about:firefoxview link from Gratitude screen

Beta/Release Uplift Approval Request

• User impact if declined: Users will see the wrong CTA on the final step of about:welcome
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: - Open about:welcome

• Navigate to last screen which should show primary CTA as 'Start browsing'
• 'Start Browsing' button should open the newtab page

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Touches only the CTA for the final about:welcome screen
• String changes made/needed: none
• Is Android affected?: Unknown

Comment 10

[Dianna Smith [:diannaS]]

Comment on attachment 9325812 [details]
Bug 1824948 - Remove about:firefoxview link from Gratitude screen

Approved for 112.0b9

Comment 11

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/7b4583618859

Comment 12

[Marius Coman [:mcoman], Ecosystem QA - PTO until 8th of November, for any requests ping :cmuresan]

I have verified this task and I can confirm the following:

• The secondary button from the "Gratitude" screen of the "about:welcome" page is no longer displayed.
• The primary button was renamed to "Start browsing".
• User is redirected to the "about:home" page if the "Start browsing" button is clicked.

Verified using the latest Firefox Nightly (113.0a1 Build ID - 20230330214245) and latest Firefox Beta (112.0b9 Build ID - 20230330182947) installed on Windows 10 x64, macOS 12.6.1, and Ubuntu 22.04 x64.