1825055 - [wpt-sync] Sync PR 39247 - Allow elements with display:contents to be focused.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 39247 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/39247
Details from upstream follow.

L. David Baron <[e-mail]> wrote:

Allow elements with display:contents to be focused.

This is as sort-of-resolved in
https://github.com/w3c/csswg-drafts/issues/2632
and as discussed a bit in
https://github.com/whatwg/html/issues/1837 .

This makes the \<slot> element focusable when it has a tabindex. Note
that this does not match Gecko and WebKit, which also require that its
'display' value is changed to make it focusable.

Note that the \<slot> element is still not tabbable in Chrome; this is
https://crbug.com/1428419. This also does not match Gecko and WebKit,
where it is tabbable whenever it is focusable. The added test
slot-element-tabbable.tentative.html fails as a result, but is added
anyway.

The added tests display-contents-focusable-001.html and
slot-element-focusable.tentative.html are partly fixed by this change,
but the style part is still broken due to https://crbug.com/1428420.

Fixed: 1366037
Bug: 1428419, 1428420
Change-Id: I46a8ad3b6442ce07f440c8f6a07210bac305600e

Reviewed-on: https://chromium-review.googlesource.com/3910374
WPT-Export-Revision: 0df7d2ba71789ffe105b723242bdcf1bb9227e29

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=b1d4c4e4f7ef1c33fc21c263d3d7d603882dd642

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests and 10 subtests

Status Summary

Firefox

OK : 4
PASS: 7
FAIL: 8

Chrome

OK : 4
PASS: 6
FAIL: 9

Safari

OK : 4
PASS: 7
FAIL: 8

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-display/display-contents-focusable-001.html [wpt.fyi]
  • element with display:contents is focusable: FAIL (Chrome: FAIL, Safari: FAIL)
• /html/rendering/non-replaced-elements/flow-content-0/slot-element-focusable.tentative.html [wpt.fyi]
  • slot element with default style should be focusable: FAIL (Chrome: FAIL, Safari: FAIL)
• /html/rendering/non-replaced-elements/flow-content-0/slot-element-tabbable.tentative.html [wpt.fyi]
  • slot element with default style should be focusable: FAIL (Chrome: FAIL, Safari: FAIL)
• /html/semantics/embedded-content/the-canvas-element/canvas-descendants-focusability-003.tentative.html [wpt.fyi]
  • <button style="display: contents" data-focusable="true">: FAIL (Chrome: FAIL, Safari: FAIL)
  • <section style="display: contents" tabindex="-1" data-focusable="true">: FAIL (Chrome: FAIL, Safari: FAIL)
  • <div style="display: contents" tabindex="-1" data-focusable="true">: FAIL (Chrome: FAIL, Safari: FAIL)
  • <span style="display: contents" tabindex="-1" data-focusable="true">: FAIL (Chrome: FAIL, Safari: FAIL)
  • <a style="display: contents" href="#" data-focusable="true">: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/750cbf39a61f
[wpt PR 39247] - Add support for allowing elements with display:contents to be focused., a=testonly
https://hg.mozilla.org/integration/autoland/rev/7c408145293b
[wpt PR 39247] - Update wpt metadata, a=testonly

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/750cbf39a61f
https://hg.mozilla.org/mozilla-central/rev/7c408145293b