1825061 - Some CSS coding is displayed in PiP while watching Hulu videos with subtitles turned off

Status: VERIFIED FIXED

(Toolkit :: Picture-in-Picture, defect)

Description

[Daniel Bodea [:danibodea]]

Attachment: demo.png

Note

• When the user logs into Hulu, plays a video, does NOT activate subtitles and then launches the PiP, he will notice that the PiP will display some CSS code as subtitles.
• If then, he turns the subtitles on from the Hulu player, he will notice that the subs are correctly displayed.
• Furthermore, if he then disables the subtitles again from the Hulu player, he will notice that both the CSS coding and the subtitles will continue to be displayed.
• This can be worked around by turning the subtitles OFF from the PiP subtitle controls.

Found in

• Nightly v113.0a1

Affected versions

• Nightly v113.0a1

Tested platforms

• Affected platforms: Ubuntu 22, Windows 10, MacOS 13
• Unaffected platforms:

Steps to reproduce

1. Log into Hulu
2. Play a video.
3. leave default subtitle settings (not enabled!)
4. Launch the PiP.

Expected result

• No subtitles are displayed in the PiP window.

Actual result

• Some CSS code is displayed as subtitles in the PiP.

Regression range

• appears to be a regression as it only occurs in Nightly.
• I've tried investigating the regression range and the best restuls I could determine are:
  Tested mozilla-central build: 2023-03-14 (verdict: g)
  Tested mozilla-central build: 2023-03-15 (verdict: b)
• All further builds would encounter a tab crash and I wasn't able to determine an exact regressor.

Additional notes

• additional_note1

Comment 1

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1825061 - Fix Hulu caption observer. r=#pip-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d0a906c8b925
Fix Hulu caption observer. r=pip-reviewers,mhowell

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/d0a906c8b925

Comment 4

[Daniel Bodea [:danibodea]]

This issue has been fixed in the latest Nightly v113.0a1. Confirmed on Win11, WIn10, Ubuntu22 , MacOS 11.