Closed Bug 1825087 Opened 3 years ago Closed 2 years ago

Mute button does not sync with PiP window on sites using Yahoo site wrapper

Categories

(Toolkit :: Picture-in-Picture, defect)

defect

Tracking

()

RESOLVED FIXED
Tracking Status
firefox119 --- affected

People

(Reporter: kpatenio, Assigned: simar.bassi)

References

Details

(Keywords: good-first-bug)

STR:

  1. Load a video on Yahoo Finance (example)
  2. Open PiP window
  3. Make sure there is sound on the video
  4. Press mute button on PiP window

Expected results:
Mute button should become unmute button on Yahoo Finance video player, matching PiP window unmute button.

Actual results:
Mute button on Yahoo Finance video player remains unchanged visually.

Note:
The mute functionality actually works, it just looks visually inconsistent. Also, this will work on any other site using the Yahoo wrapper.

Severity: -- → S3
Keywords: good-first-bug

Reproduced on Firefox 119.0b1 with Windows 10, accessing vimeo link.

Same issue on Firefox 120.0 with Mac12.6, while accessing instagram.

Hi, is it ok if I can work on this bug?

This is my first time using bugzilla so I apologize for any inconveniences.

Flags: needinfo?(mhowell)

Sure! Thanks for offering! I will mark the bug as assigned to you to indicate that you're working on it; you'll be able to unassign yourself if that changes.

Assignee: nobody → simar.bassi
Status: NEW → ASSIGNED
Flags: needinfo?(mhowell)

I was able to reproduce the bug on vimeo and I fixed it by adding a video wrapper for it. Should I make a PR for it linking it to this issue.

Also, I was unable to reproduce the bug on Yahoo using this video. I used that video because the original one was not playing.

By the way, I am using Firefox version 120.0.1.

Flags: needinfo?(mhowell)

I was able to reproduce the bug on vimeo and I fixed it by adding a video wrapper for it. Should I make a PR for it linking it to this issue.

Please file a separate issue for Vimeo, since this one is about Yahoo.

Also, I was unable to reproduce the bug on Yahoo using this video. I used that video because the original one was not playing.

I'm not able to reproduce it either, actually. It looks like we probably fixed this over in bug 1816656, and we just didn't get this one updated at that time. Sorry about that. I'm going to close this bug now so that it's in the correct state. Looking forward to getting that Vimeo fix though, thank you for doing that.

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Flags: needinfo?(mhowell)
Resolution: --- → FIXED
See Also: → 1816656
You need to log in before you can comment on or make changes to this bug.