1825099 - [wpt-sync] Sync PR 39255 - Reject kernelMatrix with 0 width in convolveMatrix filters.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 39255 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/39255
Details from upstream follow.

Jean-Philippe Gravel <[e-mail]> wrote:

Reject kernelMatrix with 0 width in convolveMatrix filters.

Only the height was checked (rejecting [] kernels) but kernels with
zero width like [[], []] were incorrectly accepted.

Change-Id: I6cf6b708b21524183733ca7906a630b695935fea

Bug: 1428652
Change-Id: I23baf05db73e679a52cd9d553d7c6308d91b56f9
Reviewed-on: https://chromium-review.googlesource.com/4377066
WPT-Export-Revision: 92a63551f917d473b22f503db51ed4e38dbdd61c

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 39255 applied with additional changes from upstream: 61728f70c48f0a016461cc13b3ad4ebe82cd5df5, 71d751d6404d9454744fdd9ad7b2f54d710731f2

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=a85e344c21c4498daf6280fe30665814d7c64456

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 1 subtests

Status Summary

Firefox

OK : 2
FAIL : 2
TIMEOUT: 1
ERROR : 1

Chrome

OK : 2
FAIL : 2
TIMEOUT: 1
ERROR : 1

Safari

OK : 2
FAIL : 2
TIMEOUT: 1
ERROR : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /html/canvas/element/filters/2d.filter.canvasFilterObject.convolveMatrix.exceptions.tentative.html [wpt.fyi]
  • Test exceptions on CanvasFilter() convolveMatrix: FAIL (Chrome: FAIL, Safari: FAIL)
• /html/canvas/offscreen/filters/2d.filter.canvasFilterObject.convolveMatrix.exceptions.tentative.html [wpt.fyi]: ERROR (Chrome: ERROR, Safari: ERROR)
  • Test exceptions on CanvasFilter() convolveMatrix: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
• /html/canvas/offscreen/filters/2d.filter.canvasFilterObject.convolveMatrix.exceptions.tentative.worker.html [wpt.fyi]
  • Test exceptions on CanvasFilter() convolveMatrix: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f3c98d905074
[wpt PR 39255] - Reject kernelMatrix with 0 width in convolveMatrix CanvasFilters., a=testonly

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/f3c98d905074