1825104 - Add tests for br_on_cast, br_on_null, etc that have extra results in addition to the ref on top of stack

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, task, P3)

Description

[Ryan Hunt [:rhunt]]

The br_on_X instructions will pop the top of the stack and branch on it depending on X. However, they can also pass additional values as extra results.

e.g.:

(block (result (ref null 0) i32 i32)
  i32.const 0
  i32.const 0
  local.get
  br_on_cast 0
  unreachable
)

We lack test coverage here and should add more.

Comment 1

[Ben Visness [:bvisness]]

Adding a dependency on bug 1949849 so we can combine our efforts.

Comment 2

[Ryan Hunt [:rhunt]]

Attachment: Bug 1825104 - wasm: Add test. r?bvisness

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/81f04ec25cc9
https://hg.mozilla.org/integration/autoland/rev/54aac4f64230
wasm: Add test. r=bvisness

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/54aac4f64230