1825144 - Replace `istanbul-instrumenter-loader` with an equivalent package in browser/components/newtab

Status: RESOLVED FIXED

(Firefox :: Messaging System, task, P2)

Description

[Emily McMinn :emcminn]

istanbul-instrumenter-loader is throwing errors relating to peer dependency with Webpack:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: activity-streams@1.14.3
npm ERR! Found: webpack@5.56.0
npm ERR! node_modules/webpack
npm ERR!   dev webpack@“5.56.0” from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer webpack@“^2.0.0 || ^3.0.0 || ^4.0.0" from istanbul-instrumenter-loader@3.0.1
npm ERR! node_modules/istanbul-instrumenter-loader
npm ERR!   dev istanbul-instrumenter-loader@“3.0.1” from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /Users/emcminn/.npm/eresolve-report.txt for a full report.
npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/emcminn/.npm/_logs/2023-03-27T21_37_42_013Z-debug-0.log
ERROR testing next working updates

istanbul-instrumenter-loader hasn't been updated in a while, either, so it might be time to replace it with an equivalent package, such as coverage-istanbul-loader

Comment 1

[Emily McMinn :emcminn]

Attachment: Bug 1825144 - Replace `istanbul-instrumenter-loader` with `coverage-istanbul-loader` in browser/components/newtab

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c2bf822e6dc2
Replace `istanbul-instrumenter-loader` with `coverage-istanbul-loader` in browser/components/newtab r=mhoye,omc-reviewers,barret

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/c2bf822e6dc2