1825215 - "undefined" string as Error.fileName in exceptions thrown by scripting.executeScript and most other extension APIs

Status: NEW

(WebExtensions :: General, enhancement, P3)

Description

[max]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/111.0

Steps to reproduce:

Exceptions from scripting.executeScript have empty stack, useless lineNumber and columnNumber, rather strange fileName that is "undefined" string, even not undefined value.

• Load any mv3 extension having the scripting and activeTab permissions.
• Inspect it, switch to console.
• try to execute some code with either invalid InjectionTarget.tabId or invalid InjectionTarget.frameIds or just in an about:blank tab (code is wrapped)

  browser.scripting.executeScript({target: {tabId: -1}, func: () => true}).
   catch(error => console.error({error}))
  

Actual results:

The function returns a Promise that is settled to an Error that provides no details on location in code and call stack:

Object { error: Error }
    error: Error: Invalid tab ID: -1
    columnNumber: 1
    fileName: "undefined"
    lineNumber: 0
    message: "Invalid tab ID: -1"
    stack: ""
    <prototype>: Error.prototype { stack: "", … }
  <prototype>: Object { … }

notice "undefined" string.

Expected results:

In the case of invalid tabId or lack of permission the generated
error has stack, fileName, lineNumber, and columnNumber set to the call site of the method: file name of background script/service worker similar to

browser.permissions.request({ permissions: [ "clipboardWrite" ] }).
    catch(error => console.error({error}))
Object { error: Error }
  error: Error: permissions.request may only be called from a user input handler
    columnNumber: 21
    fileName: "debugger eval code"
    lineNumber: 1
    message: "permissions.request may only be called from a user input handler"
    stack: "@debugger eval code:1:21\n"
    <prototype>: Error.prototype { stack: "", … }
  <prototype>: Object { … }

Comment 1

[max]

Besides invalid InjectionTarget.target.frameIds it may happen with a sandbox <iframe>

<iframe id="iframe" sandbox="" src="iframe-content.html" height="480"></iframe>

I am confused by the Bug #1739643. Accordingly to it I expect no exception for a sandboxed iframe, but I get Error: Missing host permission for the tab or frames. Before I noticed that bug I was sure that for an about:blank tab ``Error: Missing host permission for the tabis expected behavior. Code evaluates successfully in the case ofabout:blank` iframe. The source of my confusion is that the bug #1411641 is still open.

Comment 2

[Alex Cornestean]

Hello,

I reproduced the issue on the latest Nightly (113.0a1/20230330214245), Beta (112.0b9/20230330182947) and Release (111.0.1/20230321111920) under Windows 10 x64 and macOS 11.3.1.

Using the attached extension (part of the example extensions pack available on MDN), which I modified to have manifest version 3 and include the scripting and activeTab permissions, running the browser.scripting.executeScript({target: {tabId: -1}, func: () => true}). catch(error => console.error({error})) code in the extensions console results in the error mentioned in Comment 0.

For more details, see the attached screenshot.

Comment 3

[Alex Cornestean]

Attachment: 2023-03-31_10h06_50.png

Comment 4

[Alex Cornestean]

Attachment: favourite-colour.xpi

Comment 5

[Rob Wu [:robwu]]

(In reply to max from comment #1)

Besides invalid InjectionTarget.target.frameIds it may happen with a sandbox <iframe>

<iframe id="iframe" sandbox="" src="iframe-content.html" height="480"></iframe>

I am confused by the Bug #1739643. Accordingly to it I expect no exception for a sandboxed iframe, but I get Error: Missing host permission for the tab or frames.

The general fix for sandbox is tracked at bug 1411641.

Comment 6

[Rob Wu [:robwu]]

This bug is not specific to the scripting.executeScript API, by the way. It happens with almost every extension API (except cases where we handle this specially, such as extension messaging).

Here is another test case:
browser.tabs.query({url:"**"}).catch(e => e)