Closed Bug 1825235 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 39267 - LoAF: Improve callback probing & source locations

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox114 fixed)

Status:
RESOLVED FIXED
Milestone:
114 Branch
Tracking Flags:
Tracking Status
firefox114 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 39267 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/39267
Details from upstream follow.

Noam Rosenthal <nrosenthal@chromium.org> wrote:

LoAF: Improve callback probing & source locations

Refactor UserCallback probe:

  • Separate UserCallback from EventListener probes,
    putting them together required a lot of conditions
    and optional args and was unnecessarily complex.

  • Pass enough info in UserCallback & EventListener probes
    for source-location capturing.
    This makes ExecuteFunction probes redundnat for LoAF,
    which is a win-win since it's an expensive probe.

  • When capturing source locations, make sure we capture
    the bound function. Added a WPT to cover this.

Bug: 1392685
Change-Id: I780a60513dc49fa15c7ea2d732f6dfad2530d5e6
Reviewed-on: https://chromium-review.googlesource.com/4376773
WPT-Export-Revision: 21cbddce8463bdfdcf0a1754f47e18b5360f1e19

PR 39267 applied with additional changes from upstream: b8e9469a49469720bb72a078c4ecde798daa70f5, d3027dd4e2fce8faa493ea0b9e6bd6507cf8651e, 6da14f4d97d5ee017f6876cc10a8469e5d8839bb, fc39740db1b060bcb59c5252ab10156a37c105fa, 1d61ce63fe96b6d59c703b7c04fb5cec511b0144, b4a4a4892b6bb3d87a77789b1ab3a3d63783365a, b6b3c22a25b94003c8e55dd60f9861d172c043c2
PR 39267 applied with additional changes from upstream: b6b3c22a25b94003c8e55dd60f9861d172c043c2, 390d91561e2d01c14b10d0986618d98c4d968e30, 07381ce7af3a53f6424066f5c2067e2d7a7e1520

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 15 tests and 1 subtests

Status Summary

Firefox

ERROR : 15

Chrome

OK : 14
PASS : 34
FAIL : 12
TIMEOUT: 1
ERROR : 1
NOTRUN : 3

Safari

ERROR : 15

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/327278fb299d [wpt PR 39267] - LoAF: Refactor user callback probes, a=testonly https://hg.mozilla.org/integration/autoland/rev/292c1889f4f6 [wpt PR 39267] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/327278fb299d
https://hg.mozilla.org/mozilla-central/rev/292c1889f4f6

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox114: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 114 Branch
You need to log in before you can comment on or make changes to this bug.