1825250 - nsRFPService::IsRFPEnabledFor should be more efficient with RPF lite enabled

Status: RESOLVED FIXED

(Core :: Security, enhancement)

Description

[Tom Schuster]

Right now we have some "efficiency checks" that just call nsContentUtils::ShouldResistFingerprinting without any context. With RFP lite enabled that code will involves three array searches. While all of these arrays are going to be smallish, we should optimize this to be constant time.

Apart from that we should consider if all those efficiency checks are actually faster than checking the cached results on Document.

Comment 1

[Tom Schuster]

Attachment: Bug 1825250 - Remove the enum value RFPTarget::IgnoreTargetAndReturnCachedValue and instead indicate changes as a return value. r?emilio

Comment 2

[Tom Schuster]

Attachment: Bug 1825250 - Change RFPTarget into bit-flags. r?tjr

Depends on D176297

Comment 3

[Tom Schuster]

Attachment: Bug 1825250 - Consider WorkerLoadInfo::mShouldResistFingerprinting as precomputed. r?tjr

The boolean is used to initialize WorkerGlobalScopeBase::mShouldResistFingerprinting which is similar
in its behavior to the precomputed mShouldResistFingerprinting in Document.

Depends on D176298

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c366df5cc857
Remove the enum value RFPTarget::IgnoreTargetAndReturnCachedValue and instead indicate changes as a return value. r=emilio
https://hg.mozilla.org/integration/autoland/rev/47ed8ace33b0
Change RFPTarget into bit-flags. r=tjr
https://hg.mozilla.org/integration/autoland/rev/f4fc1d8e910f
Consider WorkerLoadInfo::mShouldResistFingerprinting as precomputed. r=tjr

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/c366df5cc857
https://hg.mozilla.org/mozilla-central/rev/47ed8ace33b0
https://hg.mozilla.org/mozilla-central/rev/f4fc1d8e910f