Closed Bug 1825411 Opened 2 years ago Closed 1 year ago

[CTW] Scroll regions with scroll offset (0,0) do not have cached scroll position

Categories

(Core :: Disability Access APIs, defect)

defect

Tracking

()

RESOLVED FIXED
115 Branch
Tracking Status
firefox115 --- fixed

People

(Reporter: nlapre, Assigned: morgan)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

In a document with a scroll region that's not scrolled, the accessible for the scroll region will have no cached scroll position, making it impossible to tell whether we're actually dealing with a scroll region in RemoteAccessibleBase. This is because of this code in BundleFieldsForCache which avoids caching scroll positions when the position is (0,0), even if we are dealing with a scroll region.

We might be able to use the scrollRange variable to indicate whether there's a scroll region. If there is, we should send a scroll position, even if it's (0,0), so that we can use the presence/absence of a scroll position as an indicator that a scroll region exists for a given Accessible in RemoteAccessible (see RemoteAccessibleBase::ApplyScrollOffset).

We should also be careful to ensure that we're removing the scroll position from the cache if the Accessible becomes unscrollable for some reason.

Severity: -- → S3
Blocks: boundsa11y
Assignee: nobody → mreschenberg
See Also: → 1828373
Attachment #9329595 - Attachment description: Bug 1825411: Cache scroll position for unscrolled scroll frames r?nlapre,Jamie → WIP: Bug 1825411: Cache scroll position for unscrolled scroll frames r?nlapre,Jamie
Attachment #9329595 - Attachment description: WIP: Bug 1825411: Cache scroll position for unscrolled scroll frames r?nlapre,Jamie → Bug 1825411: Cache scroll position for unscrolled scroll frames r?nlapre,Jamie
Pushed by mreschenberg@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fa9772a45927
Cache scroll position for unscrolled scroll frames r=nlapre

Backed out with Bug 1828373 and Bug 1825611 for accessible failures on on /browser_general.js

Pushed by mreschenberg@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a765e16b163a
Cache scroll position for unscrolled scroll frames r=nlapre
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: