1825431 - Reader mode shortcut is not keyboard-layout-portable on Linux

Status: NEW

(Toolkit :: Reader Mode, defect, P3)

Description

[:Gijs (he/him)]

Found through bug 1814884.

We use 2 different l10n ids and 2 different shortcuts on en-US.

On Windows, we use F9, but we lumped Linux in with macOS instead of Windows, which was the wrong call. My mistake in addressing bug 1438308, 5 years ago.

Apparently nobody has reported this since...

I'm not actually sure if we can "just" change the code and rename the string, or if we should use a new string ID for the Windows+Linux case to alert localizers to the same possibility. I think the former should be OK, but I'd like a second opinion - flod? (not urgent, please wait until back from pto!)

Comment 1

[Francesco Lodolo [:flod]]

https://searchfox.org/mozilla-central/rev/0907529ff72c456ddb47839f5f7ba16291f28dce/browser/base/content/browser-sets.inc#227-232

#ifdef XP_WIN
         data-l10n-id="reader-mode-toggle-shortcut-windows"
#else
         data-l10n-id="reader-mode-toggle-shortcut-other"
         modifiers="accel,alt"
#endif

I'm not actually sure if we can "just" change the code and rename the string

I assume you mean using reader-mode-toggle-shortcut-windows for Linux in the ifdef? I'd be OK with that, as locales should not need to customize a F9 shortcut (while they might with letters). The only downside is confusion for developers, who see a window key used on Linux, but fixing that would require introducing a new Fluent ID (+ migration).