1825467 - Perma [Tier-2] LinuxCCOV /builds/worker/checkouts/gecko/xpcom/base/nsMemoryReporterManager.cpp:1340:14: error: no member named 'phc' in namespace 'mozilla'

Status: RESOLVED FIXED

(Core :: Memory Allocator, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: nbeleuzu [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=410742872&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/c34DyxkoTLutaBglhbpo5w/runs/0/artifacts/public/logs/live_backing.log

---

[task 2023-03-30T03:39:46.615Z] 03:39:46     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/security/nss/lib/mozpkix/mozpkix_mozpkix-testlib'
[task 2023-03-30T03:39:46.887Z] 03:39:46     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/xpcom/base'
[task 2023-03-30T03:39:46.891Z] 03:39:46     INFO -  /builds/worker/fetches/clang/bin/clang++ --sysroot /builds/worker/fetches/sysroot-x86_64-linux-gnu -Qunused-arguments -std=gnu++17 -o Unified_cpp_xpcom_base2.o -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -I/builds/worker/workspace/obj-build/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fstack-clash-protection -DNDEBUG=1 -DTRIMMED=1 -DMOZ_PHC -DOS_POSIX=1 -DOS_LINUX=1 -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/xpcom/base -I/builds/worker/workspace/obj-build/xpcom/base -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/checkouts/gecko/xpcom/build -I/builds/worker/checkouts/gecko/dom/base -I/builds/worker/checkouts/gecko/mfbt -I/builds/worker/checkouts/gecko/netwerk/base -I/builds/worker/checkouts/gecko/xpcom/ds -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fcrash-diagnostics-dir=/builds/worker/artifacts -fno-exceptions -fPIC -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g1 -Xclang -load -Xclang /builds/worker/workspace/obj-build/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -fno-omit-frame-pointer -funwind-tables -Wall -Wbitfield-enum-conversion -Wdeprecated-this-capture -Wempty-body -Wformat-type-confusion -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtautological-constant-in-range-compare -Wtype-limits -Wno-error=tautological-type-limit-compare -Wunreachable-code -Wunreachable-code-return -Wunused-but-set-parameter -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wc++2a-compat -Wenum-compare-conditional -Wenum-float-conversion -Wno-ambiguous-reversed-operator -Wno-error=deprecated -Wno-error=deprecated-anon-enum-enum-conversion -Wno-error=deprecated-enum-enum-conversion -Wno-error=deprecated-pragma -Wno-error=deprecated-this-capture -Wcomma -Wimplicit-fallthrough -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wno-error=atomic-alignment -Wno-error=deprecated-builtins -Wformat -Wformat-security -Wno-psabi -Wthread-safety -Wno-unknown-warning-option -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/gtk-3.0 -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/pango-1.0 -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/glib-2.0 -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/cairo -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/pixman-1 -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/freetype2 -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/libpng12 -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/gdk-pixbuf-2.0 -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/gio-unix-2.0/ -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/harfbuzz -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/atk-1.0 -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/at-spi2-atk/2.0 -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/at-spi-2.0 -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/dbus-1.0 -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/lib/x86_64-linux-gnu/dbus-1.0/include -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/gtk-3.0/unix-print -pthread @/builds/worker/workspace/obj-build/code_coverage_cflags -fno-strict-aliasing -ffp-contract=off  -MD -MP -MF .deps/Unified_cpp_xpcom_base2.o.pp   Unified_cpp_xpcom_base2.cpp
[task 2023-03-30T03:39:46.891Z] 03:39:46     INFO -  In file included from Unified_cpp_xpcom_base2.cpp:47:
[task 2023-03-30T03:39:46.891Z] 03:39:46    ERROR -  /builds/worker/checkouts/gecko/xpcom/base/nsMemoryReporterManager.cpp:1340:14: error: no member named 'phc' in namespace 'mozilla'
[task 2023-03-30T03:39:46.891Z] 03:39:46     INFO -      mozilla::phc::MemoryUsage usage;
[task 2023-03-30T03:39:46.891Z] 03:39:46     INFO -      ~~~~~~~~~^
[task 2023-03-30T03:39:46.891Z] 03:39:46    ERROR -  /builds/worker/checkouts/gecko/xpcom/base/nsMemoryReporterManager.cpp:1341:5: error: use of undeclared identifier 'ReplaceMalloc'
[task 2023-03-30T03:39:46.891Z] 03:39:46     INFO -      ReplaceMalloc::PHCMemoryUsage(usage);
[task 2023-03-30T03:39:46.891Z] 03:39:46     INFO -      ^
[task 2023-03-30T03:39:46.891Z] 03:39:46     INFO -  2 errors generated.
[task 2023-03-30T03:39:46.891Z] 03:39:46    ERROR -  gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:670: Unified_cpp_xpcom_base2.o] Error 1
[task 2023-03-30T03:39:46.891Z] 03:39:46     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/xpcom/base'
[task 2023-03-30T03:39:46.891Z] 03:39:46     INFO -  gmake[4]: Target 'target-objects' not remade because of errors.
[task 2023-03-30T03:39:46.891Z] 03:39:46    ERROR -  gmake[3]: *** [/builds/worker/checkouts/gecko/config/recurse.mk:72: xpcom/base/target-objects] Error 2
[task 2023-03-30T03:39:46.895Z] 03:39:46     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/security/nss/lib/softoken/softoken_softokn'

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1822451

:pbone, since you are the author of the regressor, bug 1822451, could you take a look?

For more information, please visit auto_nag documentation.

Comment 2

[Geoff Lankow (:darktrojan)]

Missing #include "replace_malloc_bridge.h" in nsMemoryReporterManager.cpp?

Comment 3

[Geoff Lankow (:darktrojan)]

The Thunderbird build is busted by this.

Comment 4

[Paul Bone [:pbone]]

Attachment: Bug 1825467 - Add missing include r=cosmins

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e5b65704ade8
Add missing include r=CosminS

Comment 6

[Cosmin Sabou [:CosminS]]

The try was green for the ccov builds but the asan/tsan builds were busted on trunk: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=e5b65704ade876bdf68641444f809e579e92f163&selectedTaskRun=NZl7P8uGTuWQmQqi6Zb2dQ.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=410783138&repo=autoland

I've backed out the patch and the regressor in order to have Thunderbird builds next time around. Will close this bug and please add the subsequent patches to bug 1822451 before relanding. Thank you.

Comment 7

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bdfeee6362cb
Backed out changeset e5b65704ade8 for causing asan/tsan build bustages on nsMemoryReporterManager.cpp.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/17f6ec70857b
Add missing include r=cosmins

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/17f6ec70857b

Comment 10

[Intermittent Failures Robot]

4 failures in 3863 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 3
• try: 1

Platform and build breakdown:

• linux64-ccov: 3
  • opt: 3
• osx-shippable: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1825467&startday=2023-03-27&endday=2023-04-02&tree=all