1825646 - [wpt-sync] Sync PR 39288 - Add support for "dropShadow" in canvasFilter.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 39288 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/39288
Details from upstream follow.

Jean-Philippe Gravel <[e-mail]> wrote:

Add support for "dropShadow" in canvasFilter.

For now, currentColor and color-scheme are not supported. These
depend on the DOM element computed style, which is not avaiable when
we do new CanvasFilter(...). To support CurrentColor and
color-schemes, we would need maintain unresolved colors in the
CanvasFilter object and resolve these colors only when the filter is
assigned to a canvas element context. This is possible, but it's better
if we only add this complexity if it's really needed.

Change-Id: I402c8a43c9e227ac3e5f363aee1946619a408716
Bug: 1428652
Reviewed-on: https://chromium-review.googlesource.com/4386673
WPT-Export-Revision: 662f39cb4fc449ef39da3a8f731997469736f0ef

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=b0208a0a93184e3528c1907293b53ac08ccacda4

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=a201d8fc9648394ff66dcad9c02646de8e54eb55

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests

Status Summary

Firefox

OK : 2
FAIL : 3
TIMEOUT: 1
ERROR : 1

Chrome

OK : 2
FAIL : 3
TIMEOUT: 1
ERROR : 1

Safari

OK : 2
FAIL : 3
TIMEOUT: 1
ERROR : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /html/canvas/element/filters/2d.filter.canvasFilterObject.dropShadow.exceptions.tentative.html [wpt.fyi]
  • Test exceptions on CanvasFilter() dropShadow object: FAIL (Chrome: FAIL, Safari: FAIL)
• /html/canvas/offscreen/filters/2d.filter.canvasFilterObject.dropShadow.exceptions.tentative.html [wpt.fyi]: ERROR (Chrome: ERROR, Safari: ERROR)
  • Test exceptions on CanvasFilter() dropShadow object: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
• /html/canvas/offscreen/filters/2d.filter.canvasFilterObject.dropShadow.exceptions.tentative.worker.html [wpt.fyi]
  • Test exceptions on CanvasFilter() dropShadow object: FAIL (Chrome: FAIL, Safari: FAIL)
• /html/canvas/element/manual/filters/tentative/canvas-filter-object-drop-shadow.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d996879ccb55
[wpt PR 39288] - Add support for "dropShadow" in CanvasFilter., a=testonly
https://hg.mozilla.org/integration/autoland/rev/cc2d8c638896
[wpt PR 39288] - Update wpt metadata, a=testonly

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/d996879ccb55
https://hg.mozilla.org/mozilla-central/rev/cc2d8c638896