1825715 - Replace disabling of ESLint rule prettier/prettier with prettier-specific disabling

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task, P2)

Description

[Mark Banner (:standard8)]

In bug 1809497 we are working towards separating the ESLint and prettier configurations. As a result, the ESLint rule prettier/prettier will no longer be used, and hence disabling it won't work.

Prettier supports the // prettier-ignore annotation, so we should use that instead.

There's also some cases that no longer need to be ignored, so I'll address those here as well.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1825715 - Replace disabling of ESLint rule prettier/prettier with prettier-specific disabling (js/). r?arai!

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1825715 - Replace disabling of ESLint rule prettier/prettier with prettier-specific disabling (other). r?Gijs!

Depends on D174216

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1825715 - Add section about ignoring formatting to ESLint docs. r?Gijs!

This also does a general clean-up of the ESLint doc.

Depends on D174217

Comment 4

[Mark Banner (:standard8)]

Attachment: Bug 1825715 - Replace generic ESLint disable statements with specific and prettier ones in testing. r?#perftest-reviewers!

Depends on D174225

Comment 5

[Phabricator Automation]

Comment on attachment 9326214 [details]
Bug 1825715 - Replace generic ESLint disable statements with specific and prettier ones in testing. r?#perftest-reviewers!

Revision D174226 was moved to bug 1825739. Setting attachment 9326214 [details] to obsolete.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f0b08e89cd1
Replace disabling of ESLint rule prettier/prettier with prettier-specific disabling (js/). r=arai
https://hg.mozilla.org/integration/autoland/rev/5ce3ad6ce483
Replace disabling of ESLint rule prettier/prettier with prettier-specific disabling (other). r=Gijs,necko-reviewers,credential-management-reviewers,devtools-reviewers,dimi
https://hg.mozilla.org/integration/autoland/rev/53faa883781a
Add section about ignoring formatting to ESLint docs. r=Gijs

Comment 7

[Cristian Tuns]

Backed out for causing node failures with checkBundles

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL checkBundles | Activity Stream bundle out of date

Comment 8

[Mark Banner (:standard8)]

Sigh, newtab.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b8249cc694e
Replace disabling of ESLint rule prettier/prettier with prettier-specific disabling (js/). r=arai
https://hg.mozilla.org/integration/autoland/rev/f48da8cfd9c1
Replace disabling of ESLint rule prettier/prettier with prettier-specific disabling (other). r=Gijs,necko-reviewers,credential-management-reviewers,devtools-reviewers,dimi
https://hg.mozilla.org/integration/autoland/rev/3f49eb8407c3
Add section about ignoring formatting to ESLint docs. r=Gijs

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/1b8249cc694e
https://hg.mozilla.org/mozilla-central/rev/f48da8cfd9c1
https://hg.mozilla.org/mozilla-central/rev/3f49eb8407c3