1825735 - Search shortcut with non-default emptySearchBehavior will not display the expected search history/browsing history

Status: RESOLVED WONTFIX

(Firefox :: Address Bar, defect)

Description

[Adrian Florinescu [:aflorinescu]]

Found in

• 113.0a1 (2023-03-30)

Affected versions

• 113.0a1

Tested platforms

• Affected platforms:
  - Windows 10
  - Mac 13
  - Ubuntu 22.04

Preconditions

• Have VPN connected to CA/US.
• Google as default search engine.
• browser.search.region set to CA/US
• browser.urlbar.trending.featureGate set to true
• browser.urlbar.update2.emptySearchBehavior set to 1 or 2 (default being 0)

Steps to reproduce

1. Open address bar.
2. Type/Paste a full address like: https://www.pathofexile.com/ several times to create a bit of history.
3. Do some google, ddg searches.
4. Open a tab and pick google search mode.
5. Open a tab and pick ddg search mode.
6. Open about:config and set browser.urlbar.trending.featureGate to false
7. Open a tab and pick google search mode.
8. Open a tab and pick ddg search mode.

Expected result
4. With browser.urlbar.update2.emptySearchBehavior set on 2, the history and search history are displayed + trending predictions (probably influenced by https://mozilla-hub.atlassian.net/browse/SNT-443)
5. History and search history are displayed.
7. History and search history are displayed.
8. History and search history are displayed.

Actual result
4. With browser.urlbar.update2.emptySearchBehavior set on 2, the history and search history are NOT displayed - only trending predictions
5. History and search history are NOT displayed.
7. History and search history are displayed.
8. History and search history are displayed.

Regression range

• Regressed by bug 1824965 feature ; will narrow it further down to the exact commit if need be at a later date

Notes

• Having browser.urlbar.trending.featureGate false reinstates functionality for non-default values of browser.urlbar.update2.emptySearchBehavior.
• The addition of https://mozilla-hub.atlassian.net/browse/SNT-443 should account for this issue.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:daleharvey, since you are the author of the regressor, bug 1824965, could you take a look?

For more information, please visit auto_nag documentation.

Comment 2

[Dale Harvey (:daleharvey)]

I wouldnt call this a regression, the urlbar can only show a certain amount of results and when trending suggestions are shown they replace the other types of results. However it is likely a behaviour we want to improve, I wasnt aware of this emptyBehaviour case but when trending.zeroPrefix is true I dont think we want to completely override Top Sites with Trending ones

Comment 3

[Dale Harvey (:daleharvey)]

I was keeping this open as we may have considered tweaking how the available slots are distributed, however we already have the ability to limit the number of trending items and not currently planning on more changed to that part of it so closing out