1825762 - The bookmark with RTL title is shown from left to right like English titles

Status: NEW

(Firefox :: Menus, defect, P2)

Description

[blinky]

Attachment: screenshot

Steps to reproduce:

1. Open data:text/html;charset=utf-8,<title>أبجد هوز حطي كلمن سعفص قرشت ثخذ ضظغ-أبجد هوز حطي كلمن سعفص قرشت ثخذ ضظغ
2. Click the bookmark star to bookmark the page.
3. Go to the Bookmarks Toolbar or Bookmarks Toolbar menu.

Actual results:

The bookmark with RTL title is shown from left to right like English titles.

Comment 1

[blinky]

Regression range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0f84b85f120f45fe6bad63d5e26b5ba4cd89f801&tochange=fd69d6b3aeb8e1e04334a0885f60966883a69c08

Regressed by: bug 1799460

Comment 2

[:Gijs (he/him)]

Emilio, can you take a look?

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The bug has a release status flag that shows some version of Firefox is affected, thus it will be considered confirmed.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1799460

Comment 5

[Emilio Cobos Álvarez (:emilio)]

So this seems the usual text-overflow behavior on ltr elements. The right way to fix this if we consider this a bug, would be to support :dir() (and dir="auto" in particular) for XUL (or make these HTML elements and use dir="auto" on the <label>.

Gijs, do you know if there's any background on why XUL never supported :dir? Anyways I'd lean on fixing this by changing menuitems to not use a <xul:label> altogether perhaps, and use a <span dir="auto" class="menuitem-label"> or so. Though not sure.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

(Note that behavior is correct with an arabic / rtl locale)

Comment 7

[Emilio Cobos Álvarez (:emilio)]

The only reason this worked was because the ellipsis in the nsTextBoxFrame implementation was part of the text...

Comment 8

[:Gijs (he/him)]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #5)

So this seems the usual text-overflow behavior on ltr elements. The right way to fix this if we consider this a bug, would be to support :dir() (and dir="auto" in particular) for XUL (or make these HTML elements and use dir="auto" on the <label>.

Gijs, do you know if there's any background on why XUL never supported :dir?

No, I do not. If I had to guess, I expect mixed-directionality was never envisaged as a frequent usecase (which is probably wrong and an LTR-centric PoV - it seems pretty obvious in hindsight that an RTL user would have LTR bookmarks/history items if they ever use popular en-US or similar websites. Unclear to me, from comment #0 / comment #6 if that is/was also broken, or not). But the person to ask would have been Ehsan, and we can't do that anymore...

Anyways I'd lean on fixing this by changing menuitems to not use a <xul:label> altogether perhaps, and use a <span dir="auto" class="menuitem-label"> or so. Though not sure.

This seems reasonable to me, though we would need to do the same for toolbarbuttons (see top portion of screenshot from comment 0), and is a pretty involved refactor, I imagine. But perhaps I'm wrong...

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1799460

Comment 10

[Pascal Chevrel:pascalc]

Emilio, what is the status of the bug? Is P1/S2 the right priority? Thanks!

Comment 11

[Emilio Cobos Álvarez (:emilio)]

I still want to get to this, but S3 probably reflects reality more.

Comment 12

[Donal Meehan [:dmeehan]]

Setting 114/115 to wontfix
Got an answer offline that the severity will be reviewed.
The fix will come in an upcoming release

Comment 13

[Emilio Cobos Álvarez (:emilio)]

Mid-aired :)