1825768 - Only set the SERP telemetry timer for pages that we know are SERPs

Status: RESOLVED FIXED

(Firefox :: Search, task, P3)

Description

[Mark Banner (:standard8)]

Currently in SearchSERPTelemetryChild we set a timer whenever a page is loaded so that we can check to see if there is SERP telemetry to report.

We should be able to do the "is this a relevant doc" checks before we set the timer. If so, this would avoid the extra spike to do nothing.

I don't think it gains us anything significant, but it would seem better to avoid a timer wake-up if we can.

Comment 1

[James Teow [:jteow]]

Attachment: Bug 1825768 - Prevent timer in SearchSERPTelemetryChild from firing on non-SERPs - r?standard8

I also moved cancelCheck to didDestroy since it seems like a common pattern amongst
other children. Once destroyed and constructed again in a new page load, isSerp should be
null again.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b217d35accf8
Prevent timer in SearchSERPTelemetryChild from firing on non-SERPs - r=Standard8

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/b217d35accf8