1825777 - [IT][philips.it] Autofill is triggered from an address number field

Status: VERIFIED FIXED

(Toolkit :: Form Autofill, defect, P2)

Description

[Hani Yacoub, Desktop QA]

Attachment: 2023-03-31_11h52_33.mp4

Found in

• 113.0a1

Affected versions

• 113.0a1

Tested platforms

• Affected platforms: Windows 11 and macOS 11

Preconditions

• browser.search.region = IT
• extensions.formautofill.creditCards.supportedCountries = IT
• Have at least one CC already saved

Steps to reproduce

1. Reach the payment form on https://www.philips.it
2. From the delivery address click on "Numero Civico" field

Expected result

• Autofill shouldn't be triggered from an address number field

Actual result

• Autofill is triggered from an address number field

Regression range

• https://phabricator.services.mozilla.com/D173852

Additional notes

• Not reproducible on Chrome.

Comment 1

[Micah [:mtigley] (she/her)]

This seems to be happening because we're only gathering credit card fields as a possibility for field names here

Then, when fathom can't recognize the field, we try to match against another set of autofill rules. Specifically, we're matching against this element string: "Numero civico*".

Interestingly, if we add "IT" as a supported region to extensions.formautofill.addresses.supportedCountries then the form autofill address fields are included. And somewhere down the line form autofill determines the house number field is NOT a CC number field and the dropdown doesn't show as a result.

I haven't quite determined where this is yet. Dimi, could you point to where this branch is happening?

Comment 2

[Micah [:mtigley] (she/her)]

After discussing with Dimi, we can just remove this regular expression:. This is fine since this was added before we had Fathom to identify CC name and CC number fields and is a more relaxed heuristic that isn't necessary anymore.

Comment 3

[Dimi Lee [:dimi]]

Attachment: Bug 1825777 - Do not run regexp-based heuristics for fields that run fathom credit card rulesets already r=#credential-management-reviewers,mtigley

Comment 4

[Dimi Lee [:dimi]]

Attachment: Bug 1825777 - Improve formautofill heuristics by always identifying address fields r=#credential-management-reviewers

At present, we don't execute address field identification for regions that don't support
address autofill. However, this impacts the accuracy of identifying credit card fields too.
This is due to the fact that if a field appears to be both an address and a credit card field,
we will consistently regard it as a credit card field if we don't execute address field heuristics.

This patch guarantees that we run both address and credit card heuristics when form autofill
is enabled for a region. We will still not autofill or capture address fields for regions
that do not support address autofill.

Depends on D179688

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bf687698c642
Improve formautofill heuristics by always identifying address fields r=mtigley,credential-management-reviewers DONTBUILD

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/bf687698c642

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:dimi, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox115 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Alin Ilea, Desktop Test Engineering]

Verified - Fixed in latest Nightly 116.0a1 (2023-06-15). The autofill dropdown is no longer triggered for Numero Civico field.