1825899 - BMO push hook shouldn't set the status flag to fixed if the leave-open keyword is set

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: API, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1804115#c15. The bug was correct left unresolved when that PR merged, but the fx113 status was still set to fixed. When leave-open is set, we should only be leaving a comment but not changing the resolution or setting any status flags.

Comment 1

[David Lawrence [:dkl]]

Ok so to be clear on the work flow so I get it correct this time.

Start
|
Always leave a comment with the commit details
|
If bug does NOT have the leave-open keyword set:
|   \ 
|     Close the bug as RESOLVED/FIXED
|     |
|     The commit was made to on the main/master (default) branch
|     |   \ 
|     |     Mark the appropriate nightly version target milestone
|     |     | 
|     |     Set the appropriate nightly status flag to 'fixed'
|     | 
|     The commit was made on a release branch (i.e. release_v111, etc.)
|    /   \
|   /      Set the appropriate status flag for the version of the branch (release_v111 => status-firefox111) to 'fixed'
|  /
| /
End

Please verify this is proper behavior.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Looks good to me!

Comment 3

[BMO Github Automation]

Attachment: [mozilla-bteam/bmo] Bug 1825899 - BMO push hook shouldn't set the status flag to fixed if the leave-open keyword is set (#2045)

Comment 4

[David Lawrence [:dkl]]

Merged
https://github.com/mozilla-bteam/bmo/commit/92e3f9cd0bcd6330632e0c8119f72377982b93a4