1825953 - Intermittent [TV] /tests/toolkit/components/extensions/test/mochitest/test_ext_dnr_upgradeScheme.html | changed preference: extensions.dnr.lastStoreUpdateTag.e9d8e846-8ce4-48c1-a66f-94a8b18e873b

Status: RESOLVED FIXED

(WebExtensions :: General, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: smolnar [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=411070071&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/IM619qP4SoKuGpG_qM_ydA/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/IM619qP4SoKuGpG_qM_ydA/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

---

INFO - TEST-OK | toolkit/components/extensions/test/mochitest/test_ext_dnr_upgradeScheme.html | took 1521ms
[task 2023-04-01T16:56:29.959Z] 16:56:29    ERROR - TEST-UNEXPECTED-FAIL | /tests/toolkit/components/extensions/test/mochitest/test_ext_dnr_upgradeScheme.html | changed preference: extensions.dnr.lastStoreUpdateTag.e9d8e846-8ce4-48c1-a66f-94a8b18e873b
[task 2023-04-01T16:56:29.959Z] 16:56:29    ERROR - TEST-UNEXPECTED-FAIL | /tests/toolkit/components/extensions/test/mochitest/test_ext_dnr_upgradeScheme.html | changed preference: extensions.webextensions.uuids
[task 2023-04-01T16:56:29.959Z] 16:56:29    ERROR - TEST-UNEXPECTED-FAIL | /tests/toolkit/components/extensions/test/mochitest/test_ext_dnr_upgradeScheme.html | changed preference: dom.ipc.keepProcessesAlive.extension
[task 2023-04-01T16:56:29.959Z] 16:56:29     INFO - TEST-START | Shutdown

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:robwu, since you are the author of the regressor, bug 1810753, could you take a look?

For more information, please visit auto_nag documentation.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1810753

Comment 3

[Rob Wu [:robwu]]

This is not a regression caused by bug 1810753. Logically there is zero change in behavior in the referenced test file (comment + 1 pref that enables the behavior before the patch): https://hg.mozilla.org/mozilla-central/rev/3208bcb7bb98#l2.2

The failure appears to happen with TV, which is understandable given that the bug touched the file.

The first of the referenced prefs were introduced in bug 1803365.
The second pref could potentially be related.
The third pref (dom.ipc.keepProcessesAlive.extension) is strange - I don't see it changing unexpectedly during the test.

Comment 4

[Intermittent Failures Robot]

5 failures in 3863 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 5

Platform and build breakdown:

• linux1804-64-qr: 2
  • debug: 1
  • opt: 1
• macosx1015-64-qr: 2
  • debug: 1
  • opt: 1
• linux1804-64-tsan-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1825953&startday=2023-03-27&endday=2023-04-02&tree=all

Comment 5

[Rob Wu [:robwu]]

This is a pre-existing issue across all test types, but only triggered in TV because the check was introduced (recently) in bug 1783248.

I can reproduce without TV by running

./mach test toolkit/components/extensions/test/mochitest/test_ext_dnr_upgradeScheme.html --compare-preferences

This issue happens because the test_ext_dnr_upgradeScheme.html test installs an in-memory Extension without useAddonManager.
Both result in (pref) storage changes that are ordinarily cleaned up in ExtensionAddonObserver.onUninstalled. But that does not happen here, because ExtensionAddonObserver is only triggered for test extensions if useAddonManager is set.

The changed pref thing is not specific to the DNR API nor test_ext_dnr_upgradeScheme.html; I just witnessed a TV failure on try in toolkit/components/extensions/test/mochitest/test_ext_webrequest_frameId.html that is independent of this bug.

Comment 6

[Rob Wu [:robwu]]

Attachment: Bug 1825953 - Move keepProcessesAlive.extension pref from head.js to mochitest*.ini

Set in test manifests instead of head.js to prevent the mochitest from
setting prefs that persist across the end of the test, resulting in:

TEST-UNEXPECTED-FAIL | /tests/toolkit/components/extensions/test/mochitest/[name].html | changed preference: dom.ipc.keepProcessesAlive.extension

when run in TV or with ./mach test --compare-preferences ...

Comment 7

[Rob Wu [:robwu]]

Attachment: Bug 1825953 - Temporarily add some extension prefs to ignorePrefs.json

Most extension mochitests are now busted in TV (--test-verify) tests
because of the changes from bug 1783248.

The cause of the failure will be addressed in a follow-up, at:
https://bugzilla.mozilla.org/show_bug.cgi?id=1826390

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e22ba4bf75e8
Move keepProcessesAlive.extension pref from head.js to  mochitest*.ini r=rpl
https://hg.mozilla.org/integration/autoland/rev/8667f9f6e281
Temporarily add some extension prefs to ignorePrefs.json r=rpl,jmaher

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/e22ba4bf75e8
https://hg.mozilla.org/mozilla-central/rev/8667f9f6e281