1825963 - Attachment icon not removed once we realize multipart/mixed email didn't have attachment after all

Status: RESOLVED FIXED

(MailNews Core :: MIME, defect)

Description

[Steve Edmonds]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0

Steps to reproduce:

Clicked on an email in the message list with an attachment icon (paperclip) showing.

Actual results:

The email when displayed, had no attachment

Expected results:

The attachment icon should not have shown.

Comment 1

[Steve Edmonds]

This is in 112.0b4 on openSuse.
This occurs with all emails from https://groups.google.com/g/diy-pid-control
Their structure is;

List-Unsubscribe: <mailto:[e-mail]>,
 <https://groups.google.com/group/diy-pid-control/subscribe>

------=_Part_104_1120712532.1680021669573
Content-Type: multipart/alternative; 
	boundary="----=_Part_105_654613545.1680021669573"

------=_Part_105_654613545.1680021669573
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

My reply didn't make it, and I've had a little experience since then.
I'm using a ThermoElectricCooler

More plain text

------=_Part_105_654613545.1680021669573
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

My reply didn't make it, and I've had a little experience since then.<div><=
br /></div><div>I'm using a ThermoElectricCooler, also for heating, reversi=

more HTML
<br />

------=_Part_105_654613545.1680021669573--

------=_Part_104_1120712532.1680021669573--

Comment 2

[Steve Edmonds]

Another place this occurs is with emails from Aliexpress.

MIME-Version: 1.0
Content-Type: multipart/mixed; 
	boundary="----=_Part_6593445_1169623937.1679576167387"
Feedback-ID: default:[e-mail]:S-others:151973

------=_Part_6593445_1169623937.1679576167387
Content-Type: text/html;charset=utf-8
Content-Transfer-Encoding: quoted-printable

<div style=3D"display:none"><img style=3D"display:none" src=3D"http://ae.mm=

more html

</body>
</html>
------=_Part_6593445_1169623937.1679576167387--

Comment 3

[Francesco]

Bug 479017 from 2009. In comment #2 you've pasted multipart/mixed, in messages from Google Groups, there's also a defective Content-Type: multipart/mixed; header further up in the message source:

Subject: Re: Bug - File is missing
MIME-Version: 1.0
Content-Type: multipart/mixed; 
	boundary="----=_Part_6328_410490908.1680404150017"
X-Original-Sender: [e-mail]
Precedence: list
Mailing-list: list [e-mail]; contact [e-mail]
List-ID: <onecommander.googlegroups.com>
X-Google-Group-Id: 64225701208
List-Post: <https://groups.google.com/group/onecommander/post>, <mailto:[e-mail]>
List-Help: <https://groups.google.com/support/>, <mailto:[e-mail]>
List-Archive: <https://groups.google.com/group/onecommander
List-Subscribe: <https://groups.google.com/group/onecommander/subscribe>, <mailto:[e-mail]>
List-Unsubscribe: <mailto:[e-mail]>,
 <https://groups.google.com/group/onecommander/subscribe>

Comment 4

[Thomas D. (:thomas8)]

• Steve, does TB release version 102 also show the attachment icon for such messages?
• What makes you think that this issue was introduced by Supernova?

Comment 5

[Steve Edmonds]

I have only noticed it since Supernova, I will check as far back as I can with mozregression.

Comment 6

[Francesco]

If you read bug 479017 comment #12 you will see that multipart/mixed messages are treated as having an attachment until you click on them and the system notices that there isn't one. No need to use mozregression (besides, it won't work since there is no "good" state since 2009 and likely before). Just use any TB ESR with version 102, 91, 78, 68, 60, 52, 45, 31, 24, 17 or so.

Comment 7

[Steve Edmonds]

(In reply to Thomas D. (:thomas8) from comment #4)

• Steve, does TB release version 102 also show the attachment icon for such messages?
• What makes you think that this issue was introduced by Supernova?

TB release version 102 shows the attachment icon and when you click on the message the icon goes away.
TB release version 112 shows the attachment icon and when you click on the message the icon does not go away.

Comment 8

[Francesco]

Apologies, thanks for clarifying. Yes, at least when clicked, the icon should go away.

Comment 9

[Magnus Melin [:mkmelin]]

Confirmed.
(See markHasAttachments)

Comment 10

[Francesco]

Looks like this code was removed:
https://searchfox.org/comm-esr102/rev/6cb844cf1b3c1d290cbb297518e4cca1c131eb70/mail/base/content/msgHdrView.js#811-835
https://searchfox.org/comm-central/rev/d50b7e7af82b460191a637dbde44c1cbc5234542/mail/base/content/msgHdrView.js#834

Comment 11

[Magnus Melin [:mkmelin]]

Thanks Francesco!

Comment 12

[Magnus Melin [:mkmelin]]

Attachment: Bug 1825963 - Reinstate code to remove attachment icon once we realize multipart/mixed email didn't have attachment after all. r=darktrojan

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8ba66a78ae60
Reinstate code to remove attachment icon once we realize multipart/mixed email didn't have attachment after all. r=darktrojan

Comment 14

[Wayne Mery (:wsmwk)]

Comment on attachment 9329183 [details]
Bug 1825963 - Reinstate code to remove attachment icon once we realize multipart/mixed email didn't have attachment after all. r=darktrojan

[Triage Comment]
Approved for beta - restoring removed code

Comment 15

[Daniel Darnell [:dandarnell]]

Thunderbird 113.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/d182a55bb757

Comment 16

[Thomas D. (:thomas8)]

Updating whiteboard to [supernova3p]. 20230424_2303