Closed
Bug 1826013
Opened 2 years ago
Closed 2 years ago
Clean up parameters to gfxTextRun::BreakAndMeasureText
Categories
(Core :: Graphics: Text, task)
Core
Graphics: Text
Tracking
()
RESOLVED
FIXED
113 Branch
| Tracking | Status | |
|---|---|---|
| firefox113 | --- | fixed |
People
(Reporter: jfkthame, Assigned: jfkthame)
References
Details
Attachments
(1 file)
In the course of bug 1825983, I noticed that a number of the pointer outparams to BreakAndMeasureText that it treats as "optional" don't need to be, as the only caller is nsTextFrame and it always passes them. So we can replace them with references, and drop some null-checks.
We can also make the PropertyProvider param a const reference, as nsTextFrame always passes it.
|
Assignee | |
Comment 1•2 years ago
|
||
|
||
Updated•2 years ago
|
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Pushed by jkew@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c40b3c6fc1c1
Tidy up BreakAndMeasureText params, and replace some never-NULL pointers with references. r=gfx-reviewers,lsalzman
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox113:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•