1826136 - [wpt-sync] Sync PR 39338 - Use the initial style for resolving if nothing better is found

Status: RESOLVED FIXED

(Core :: Web Painting, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 39338 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/39338
Details from upstream follow.

Fredrik Söderquist <[e-mail]> wrote:

Use the initial style for resolving if nothing better is found

We need a ComputedStyle to be able to resolve from a SVGLength (really:
a CSSPrimitiveValue) to a Length. Previously[1] we could resolve
absolute units since that did require any (style) context. By providing
the initial computed style in the cases where we fail to find one by
other means, we will manage to resolve a value. This will also mean that
certain units, like font-relative ones, will start resolving based on
the initial computed style.

In the specific case we would reject the filter as invalid because the
filter region would resolve to an empty rectangle. This happens to work
for HTML content, because there we ignore this condition.

[1] Before 25aa3b1a70b4c45070f70e5e2ea0e26e01697c49

Bug: 1429510
Change-Id: I9bb755ede064aa902ff7334356cc6e0660d25474

Reviewed-on: https://chromium-review.googlesource.com/4394132
WPT-Export-Revision: debacae32a113252df010e6a7765dfa0608674ed

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=20f588386062c04ead45809c676436eef838f0c2

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/filter-effects/svg-external-filter-resource.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c9b70be1362d
[wpt PR 39338] - Use the initial style for resolving if nothing better is found, a=testonly
https://hg.mozilla.org/integration/autoland/rev/9c509fc9d0f1
[wpt PR 39338] - Update wpt metadata, a=testonly

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/c9b70be1362d
https://hg.mozilla.org/mozilla-central/rev/9c509fc9d0f1