Closed
Bug 1826154
Opened 2 years ago
Closed 8 months ago
[Tabs tray to Compose] Add `TabsTrayFab` to `TabsTray` preview and refactor `TabsTray` previews
Categories
(Fenix :: Tabs, task, P5)
Tracking
(firefox129 fixed)
RESOLVED
FIXED
129 Branch
| Tracking | Status | |
|---|---|---|
| firefox129 | --- | fixed |
People
(Reporter: 007, Assigned: npoon2003)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fxdroid][group4])
Attachments
(1 file)
Until BottomSheetBehavior is no longer needed and TabsTray can instead use a proper bottom sheet Composable, the FAB is not able to live in the TabsTray top-level composable. It would still be useful having TabsTrayFab inside of the TabsTray previews.
As part of this ticket:
- Add the fab composable to the
TabsTraypreviews. - Plumb-in some basic logic to add a tab to the appropriate tab page (i.e. when on normal or private) when the fab is clicked.
|
Reporter | |
Updated•10 months ago
|
Whiteboard: [fxdroid][group4]
|
||
Updated•10 months ago
|
|
Assignee | |
Comment 1•10 months ago
|
||
I would like to work on this issue
|
||
Updated•9 months ago
|
Assignee: nobody → npoon
|
|
||
Updated•9 months ago
|
Assignee: npoon → npoon2003
|
|
Assignee | |
Comment 2•9 months ago
|
||
|
|
||
Updated•9 months ago
|
Summary: [Tabs tray to Compose] Add `TabsTrayFab` to `TabsTray` preview → [Tabs tray to Compose] Add `TabsTrayFab` to `TabsTray` preview and refactor `TabsTray` previews
|
||
Updated•9 months ago
|
Attachment #9402328 -
Attachment description: WIP: Bug 1826154 - Add `TabsTrayFab` to `TabsTray` preview → Bug 1826154 - Add `TabsTrayFab` to `TabsTray` preview
|
|
||
Updated•9 months ago
|
Attachment #9402328 -
Attachment description: Bug 1826154 - Add `TabsTrayFab` to `TabsTray` preview → Bug 1826154 - Add `TabsTrayFab` to `TabsTray` preview and refactor `TabsTray` previews
Pushed by calu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fdc3933e985f
Add `TabsTrayFab` to `TabsTray` preview and refactor `TabsTray` previews r=android-reviewers,007
Status: NEW → RESOLVED
Closed: 8 months ago
status-firefox129:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 129 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•