Closed Bug 1826159 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 39340 - Revert "Fix Flaky WPT for testing calc with mixed units in media queries"

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox114 fixed)

RESOLVED FIXED
114 Branch
Tracking Status
firefox114 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 39340 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/39340
Details from upstream follow.

Owen Min <zmin@chromium.org> wrote:

Revert "Fix Flaky WPT for testing calc with mixed units in media queries"

This reverts commit a1a8f2f665ca969f429e292c1396edd4f406a8e6.

Reason for revert: The test is still failing
Build:
https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/112441/overview

Original change's description:

Fix Flaky WPT for testing calc with mixed units in media queries

The WPT for testing whether the calc function is working as expected
when invoked with different units inside and iframe has turned flaky.
[UNEXPECTED TIMEOUT]

This CL attempts to fix the flakiness by using srddoc attribute to get
the contents of all the iframe directly rather than loading it from HTML
files from support directory.

Bug: 1385642
Change-Id: Ib8cb23d1ebb77542e6deb8254629ad0124b88261
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4369590
Reviewed-by: Anders Hartvoll Ruud \<andruud@chromium.org>
Commit-Queue: Anders Hartvoll Ruud \<andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1125308}

Bug: 1385642
Change-Id: Idae0f2b60586006a1f65469a139cebf6a0963732
No-Presubmit: true
No-Tree-Checks: true
No-Try: true

Reviewed-on: https://chromium-review.googlesource.com/4392637
WPT-Export-Revision: 5fb9a0de496eb96fe3d1c959a84a5f6138147f46

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d9e1308967f4 [wpt PR 39340] - Revert "Fix Flaky WPT for testing calc with mixed units in media queries", a=testonly
Test result changes from PR not available.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 114 Branch
You need to log in before you can comment on or make changes to this bug.