1826174 - [DNR] Add test case for service worker redirect in DNR

Status: RESOLVED FIXED

(WebExtensions :: Request Handling, task, P3)

Description

[Rob Wu [:robwu]]

Bug 1636629 added special code in WebRequest.jsm (verifyRedirect) that prevents extensions from trying to redirect service workers and restrictions for redirects of importScripts calls in service workers.

This check is not strictly required: if an extension redirects a service worker, then the redirect will be rejected anyway. Similarly, if the destination is an invalid scheme, then an import is rejected. We should add a unit test for DNR-triggered SW script redirection.

Note: I'm inclined to only add a test case and not raise an explicit error from DNR. This means that DNR-triggered redirects can break service workers. This is not an issue IMO: there are other redirects (in webRequest and DNR) that can also end up in a blocked redirect, and we don't prevent that from happening either. Examples are redirect to destination that would be blocked by CSP, or blocked by SRI mismatch, etc.

Comment 1

[Rob Wu [:robwu]]

Attachment: Bug 1826174 - Add test for SW script redirects with DNR

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3237828cc1b3
Add test for SW script redirects with DNR r=rpl

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/3237828cc1b3