Closed Bug 1826208 Opened 2 years ago Closed 1 year ago

[wpt-sync] Sync PR 39347 - Event Timing flush pointerdown on contextmenu

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox122 fixed)

Status:
RESOLVED FIXED
Milestone:
122 Branch
Tracking Flags:
Tracking Status
firefox122 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Regressed 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 39347 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/39347
Details from upstream follow.

Aoyuan Zuo <zuoaoyuan@chromium.org> wrote:

Event Timing flush pointerdown on contextmenu

  • previous undesired outcome: When right click brings up
    contextmenu, the pointerdown entry is missing the first time you
    do so.
  • root cause: pointerdown entries are deferred notifying PO until
    pointercancel or pointerup. But in this issue, the pointerdown is
    only followed by a contextmenu, so it gets stuck in the map. The
    stuck entry can only be resecued when a new pointerdown comes in
    to substitute it out. This explains why only the first pointerdown
    was missing. Also, it shows that all subsequent right clicks were
    printing pointerdowns, but are the incorrect previous ones stuck in
    the map.
  • this cl address it by: treating contextmenu similar to
    pointercancel. However, since contextmenu doesn't have a valid
    pointer_id to match with, we flash the whole map instead.

Bug: 1413096, 1428603
Change-Id: I03e9cdbe57c146fe61e6758b39249048aa982897
Reviewed-on: https://chromium-review.googlesource.com/4288967
WPT-Export-Revision: 6ce767ddc546cfba020f07553de9ba9834d2aeea

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 50 tests and 1 subtests

Status Summary

Firefox

OK : 44[Gecko-windows11-32-2009-qr-opt] 45[Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 47[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] 48[GitHub]
PASS : 29[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-opt, GitHub] 30[Gecko-windows11-64-2009-qr-debug]
FAIL : 15[Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug] 16[Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 18[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] 19[GitHub]
TIMEOUT: 2[Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 4[GitHub]
ERROR : 1

Chrome

OK : 49
PASS : 49
TIMEOUT: 2

Safari

OK : 50
FAIL : 50

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

  • /event-timing/first-input-interactionid-tap.html [wpt.fyi]: OK [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview], SKIP [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], TIMEOUT [GitHub]
  • /event-timing/interactionid-tap.html [wpt.fyi]: OK [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview], SKIP [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], TIMEOUT [GitHub]

New Tests That Don't Pass

  • /event-timing/first-input-interactionid-tap.html [wpt.fyi]: OK [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview], SKIP [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], TIMEOUT [GitHub] (Chrome: OK, Safari: OK)
    • The interactionId of the first input entry should match the same pointerdown entry of event timing when tap.: FAIL [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview], TIMEOUT [GitHub] (Chrome: PASS, Safari: FAIL)
  • /event-timing/interactionid-tap.html [wpt.fyi]: OK [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview], SKIP [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], TIMEOUT [GitHub] (Chrome: OK, Safari: OK)
    • Event Timing: compare event timing interactionId for tap.: FAIL [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview], TIMEOUT [GitHub] (Chrome: PASS, Safari: FAIL)
  • /layout-instability/input-timestamp.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: OK, Safari: OK)
    • Layout shift right after user input is observable via PerformanceObserver.: FAIL (Chrome: PASS, Safari: FAIL)
  • /layout-instability/recent-input.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: OK, Safari: OK)
    • Layout shift right after user input is observable via PerformanceObserver.: FAIL (Chrome: PASS, Safari: FAIL)
  • /event-timing/crossiframe.html [wpt.fyi]
    • Event Timing: entries should only be observable by its own frame.: FAIL (Chrome: PASS, Safari: FAIL)
  • /event-timing/disconnect-target.html [wpt.fyi]
    • Event Timing: when target is disconnected, entry.target returns null.: FAIL (Chrome: PASS, Safari: FAIL)
  • /event-timing/duration-with-target-low.html [wpt.fyi]: OK [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub], SKIP [Gecko-windows11-32-2009-qr-opt] (Chrome: OK, Safari: OK)
    • PerformanceObserver with durationThreshold of 300 and processingDelay of 0 doesn't see any entries in the observer: FAIL [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-windows11-64-2009-qr-debug] (Chrome: PASS, Safari: FAIL)
  • /event-timing/event-click-visibilitychange.html [wpt.fyi]: ERROR [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview], OK [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub] (Chrome: OK, Safari: OK)
  • /event-timing/event-retarget.html [wpt.fyi]
    • Event Timing: target reports the last Event Target, i.e. nothing from shadow DOM.: FAIL (Chrome: PASS, Safari: FAIL)
  • /event-timing/first-input-interactionid-click.html [wpt.fyi]
    • The interactionId of the first input entry should match the same pointerdown entry of event timing when click.: FAIL (Chrome: PASS, Safari: FAIL)
  • /event-timing/interaction-count-click.html [wpt.fyi]
    • EventTiming: verify interactionCount for click interaction: FAIL (Chrome: PASS, Safari: FAIL)
  • /event-timing/interaction-count-press-key.html [wpt.fyi]
    • EventTiming: verify interactionCount for key interaction: FAIL (Chrome: PASS, Safari: FAIL)
  • /event-timing/interaction-count-tap.html [wpt.fyi]
    • EventTiming: verify interactionCount for tap interaction: FAIL (Chrome: PASS, Safari: FAIL)
  • /event-timing/interactionid-aux-pointerdown-and-pointerdown.html [wpt.fyi]
    • Event Timing: verify pointerdown reporting for mouse aux pointerdown only triggered contextmenu followed immediately by another pointerdown event.: FAIL (Chrome: PASS, Safari: FAIL)
  • /event-timing/interactionid-aux-pointerdown.html [wpt.fyi]
    • Event Timing: verify pointerdown reporting for mouse aux pointerdown only triggered contextmenu.: FAIL (Chrome: TIMEOUT, Safari: FAIL)
  • /event-timing/interactionid-auxclick.html [wpt.fyi]: OK [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, GitHub], TIMEOUT [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: OK, Safari: OK)
    • Event Timing: verify pointerdown & pointerup reporting for mouse aux click triggered contextmenu.: FAIL [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, GitHub], TIMEOUT [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: PASS, Safari: FAIL)
  • /event-timing/interactionid-click.html [wpt.fyi]
    • Event Timing: compare event timing interactionId.: FAIL (Chrome: PASS, Safari: FAIL)
  • /event-timing/interactionid-press-key-as-input.html [wpt.fyi]
    • Event Timing: compare event timing interactionId for key press as input.: FAIL (Chrome: PASS, Safari: FAIL)
  • /event-timing/interactionid-press-key-no-effect.html [wpt.fyi]
    • Event Timing: compare event timing interactionId for key press with no effect.: FAIL (Chrome: PASS, Safari: FAIL)
  • /event-timing/only-observe-firstInput.html [wpt.fyi]
    • Event Timing: check first-input for a PerformanceObserver observing only first-input.: FAIL (Chrome: PASS, Safari: FAIL)
  • /event-timing/programmatic-click-not-observed.html [wpt.fyi]
    • Event Timing: events from programmatic click are not observed: FAIL (Chrome: PASS, Safari: FAIL)
  • /event-timing/retrieve-firstInput.html [wpt.fyi]
    • Event Timing: check first-input after onload, observer, click, click.: FAIL (Chrome: PASS, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

  • /event-timing/first-input-interactionid-tap.html [wpt.fyi]: OK [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview], SKIP [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], TIMEOUT [GitHub] (Chrome: OK, Safari: OK)
  • /event-timing/interactionid-tap.html [wpt.fyi]: OK [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview], SKIP [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], TIMEOUT [GitHub] (Chrome: OK, Safari: OK)
  • /layout-instability/input-timestamp.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: OK, Safari: OK)
  • /layout-instability/recent-input.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: OK, Safari: OK)
  • /event-timing/duration-with-target-low.html [wpt.fyi]: OK [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub], SKIP [Gecko-windows11-32-2009-qr-opt] (Chrome: OK, Safari: OK)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0fc22d8a9c7c [wpt PR 39347] - Event Timing flush pointerdown & keydown on contextmenu, a=testonly https://hg.mozilla.org/integration/autoland/rev/f63ea4dd8c4d [wpt PR 39347] - Update wpt metadata, a=testonly
Regressions: 1867234

https://hg.mozilla.org/mozilla-central/rev/0fc22d8a9c7c
https://hg.mozilla.org/mozilla-central/rev/f63ea4dd8c4d

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox122: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 122 Branch
You need to log in before you can comment on or make changes to this bug.