1826304 - Update libprio-rs to 0.12.0

Status: RESOLVED FIXED

(Toolkit :: Telemetry, enhancement)

Comment 1

[Simon Friedberger (:simonf)]

Attachment: Bug 1826304: Update libprio-rs to 0.12.0. r=emilio

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1826304 - Update base64 in some in-tree crates. r=glandium!

Depends on D175099

Comment 3

[Simon Friedberger (:simonf)]

Attachment: Bug 1826304: Switch to SHA3 based PRG. r=emilio

Depends on D175099

Comment 4

[Simon Friedberger (:simonf)]

Attachment: Bug 1826304: Switch to SHA3 based PRG. r=emilio

Depends on D175099

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/694a4c9a4085
Update base64 in some in-tree crates. r=glandium,webdriver-reviewers,necko-reviewers,supply-chain-reviewers,jesup,jgraham,emilio

Comment 6

[Sandor Molnar[:smolnar]]

Backed out for causing for causing xpc failures in security/manager/ssl/tests/unit/test_cert_storage.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/5b4d23a895a9b93498da683563537b4198bd3e37

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | security/manager/ssl/tests/unit/test_cert_storage.js | - verifying EE Revoked By Subject and PubKey: should get error -8180 - 0 == -8180

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Before:

 0:04.52 pid:184677 [security/manager/ssl/cert_storage/src/lib.rs:230] &l = "\\tVCIlmPM9NkgFQtrs4Oa5TeFcDu6MWRTKSNdePEhOgD8"
 0:04.52 pid:184677 [security/manager/ssl/cert_storage/src/lib.rs:238] base64::decode(&l[1..]) = Ok(
 0:04.52 pid:184677     [
 0:04.52 pid:184677         84,
 0:04.52 pid:184677         34,
 0:04.52 pid:184677         37,
 0:04.52 pid:184677         152,
 0:04.52 pid:184677         243,
 0:04.52 pid:184677         61,
 0:04.52 pid:184677         54,
 0:04.52 pid:184677         72,
 0:04.52 pid:184677         5,
 0:04.52 pid:184677         66,
 0:04.52 pid:184677         218,
 0:04.52 pid:184677         236,
 0:04.52 pid:184677         224,
 0:04.52 pid:184677         230,
 0:04.52 pid:184677         185,
 0:04.52 pid:184677         77,
 0:04.52 pid:184677         225,
 0:04.52 pid:184677         92,
 0:04.52 pid:184677         14,
 0:04.52 pid:184677         238,
 0:04.52 pid:184677         140,
 0:04.52 pid:184677         89,
 0:04.52 pid:184677         20,
 0:04.52 pid:184677         202,
 0:04.52 pid:184677         72,
 0:04.52 pid:184677         215,
 0:04.52 pid:184677         94,
 0:04.52 pid:184677         60,
 0:04.52 pid:184677         72,
 0:04.52 pid:184677         78,
 0:04.52 pid:184677         128,
 0:04.52 pid:184677         63,
 0:04.52 pid:184677     ],
 0:04.52 pid:184677 )

After:

 0:05.52 pid:184504 [security/manager/ssl/cert_storage/src/lib.rs:230] &l = "\\tVCIlmPM9NkgFQtrs4Oa5TeFcDu6MWRTKSNdePEhOgD8"
 0:05.52 pid:184504 [security/manager/ssl/cert_storage/src/lib.rs:238] base64::decode(&l[1..]) = Err(
 0:05.52 pid:184504     InvalidPadding,
 0:05.52 pid:184504 )

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Hi Dana! So, a cert_storage cert is relying on non-canonical base64 padding: https://searchfox.org/mozilla-central/rev/272d4c3700c8519e69bafb39b1ec755110455360/security/manager/ssl/tests/unit/test_cert_storage.js#99

I can preserve the behavior from the old base64 crate (I updated the revision with that approach), but I could also just fix the test, which would be slightly simpler. Do you have a strong opinion?

Comment 9

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Yes, please fix the test (although, I believe what needs fixing is this: https://searchfox.org/mozilla-central/rev/31f5847a4494b3646edabbdd7ea39cb88509afe2/security/manager/ssl/tests/unit/test_onecrl/sample_revocations.txt#36. Also, it would be nice to update https://searchfox.org/mozilla-central/rev/31f5847a4494b3646edabbdd7ea39cb88509afe2/security/manager/ssl/tests/unit/test_cert_storage.js#190 to be correct as well. Thanks!)

Comment 10

[Emilio Cobos Álvarez (:emilio)]

Ah, you're correct of course. Doing both, thank you!

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d0e7f5fc08da
Update base64 in some in-tree crates. r=glandium,webdriver-reviewers,necko-reviewers,supply-chain-reviewers,jesup,jgraham,emilio

Comment 12

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/d0e7f5fc08da

Comment 13

[David Cook [:dncook]]

Simon and I were previously debugging the DAP client changes in this bug. Here are the two remaining draft-ietf-ppm-dap-04 protocol compatibility issues I identified, referring to revision D175099.

First, in toolkit/components/telemetry/dap/ffi/src/lib.rs, make_base_info(), the application info string should be updated to start with dap-04 input share.

Second, in get_dap_report_internal(), in the same file, the input shares need to be encapsulated in PlaintextInputShare structures before being encrypted. This step is new as of draft-04, and was added to allow for per-aggregator extensions. Ultimately, aggregators will expect to see two length prefixes in the plaintext before the VDAF input share starts, but the code currently encrypts the VDAF input share messages directly.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d90ee96c537b
Update libprio-rs to 0.12.0. r=emilio,glandium,supply-chain-reviewers

Comment 15

[Cristina Horotan [:chorotan]]

Backed out for causing build bustages at rust.mk

Backout: https://hg.mozilla.org/integration/autoland/rev/20ddf56bef8aad155f52ba245320dacf0107aadf

Failure push: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=d90ee96c537befb53abb0c0184c82070219e2226

Failure log:https://treeherder.mozilla.org/logviewer?job_id=420121453&repo=autoland&lineNumber=65516

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/254a52c4cac8
Update libprio-rs to 0.12.0. r=emilio,glandium,supply-chain-reviewers

Comment 17

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/254a52c4cac8

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/248dda87ba0b
Switch to SHA3 based PRG. r=emilio,supply-chain-reviewers

Comment 19

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/248dda87ba0b