Closed Bug 1826316 Opened 2 months ago Closed 2 months ago

Consider not complaining about the lack of settings file for new profiles ("No settings file exists, new profile?")

Categories

(Firefox :: Search, defect, P3)

Product:
Firefox
Component:
Search
Platform:
Desktop
All
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
113 Branch
Tracking Flags:
Tracking Status
firefox113 --- fixed

People

(Reporter: Gijs, Assigned: standard8)

Details

Attachments

(1 file)

Bug 1826316 - Change logging about lack of search settings file to debug only. r?#search-reviewers!
48 bytes, text/x-phabricator-request
Details | Review

This showed up in bug 1814884. It's "just" an error message, but it's a little annoying. It'd be nice if we didn't log this for each new profile. We should be able to know that this is the first run of a profile and just not show an error in that case.

Looking around, it seems that nsIBrowserHandler knows about first run, but that is currently first loaded after the SearchService is initialised. Rather than bring that forwards, lets demote this to a debug message. It was added at a time when we were concerned about the stability of the search file, but we don't have those concerns any more.

Assignee: nobody → standard8
Status: NEW → ASSIGNED
Severity: -- → N/A
Priority: -- → P3
Severity: N/A → S4
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f794610ca677
Change logging about lack of search settings file to debug only. r=search-reviewers,mcheang

https://hg.mozilla.org/mozilla-central/rev/f794610ca677

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
status-firefox113: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
You need to log in before you can comment on or make changes to this bug.