1826316 - Consider not complaining about the lack of settings file for new profiles ("No settings file exists, new profile?")

Status: RESOLVED FIXED

(Firefox :: Search, defect, P3)

Description

[:Gijs (he/him)]

This showed up in bug 1814884. It's "just" an error message, but it's a little annoying. It'd be nice if we didn't log this for each new profile. We should be able to know that this is the first run of a profile and just not show an error in that case.

Comment 1

[Mark Banner (:standard8)]

Looking around, it seems that nsIBrowserHandler knows about first run, but that is currently first loaded after the SearchService is initialised. Rather than bring that forwards, lets demote this to a debug message. It was added at a time when we were concerned about the stability of the search file, but we don't have those concerns any more.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1826316 - Change logging about lack of search settings file to debug only. r?#search-reviewers!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f794610ca677
Change logging about lack of search settings file to debug only. r=search-reviewers,mcheang

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/f794610ca677