1826418 - about:protections doesn't count fingerprinters

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, defect, P3)

Description

[Tom Ritter [:tjr]]

My about:protections page reports no fingerprinting scripts blocked. However if I visit e.g. cnn.com - it shows me that it has blocked some fingerprinting scripts.

Comment 1

[Tim Huang[:timhuang]]

Hello Tom,

We actually count the tracker after the document is closed. Could you verify if the counter increases after you close the CNN tab? Thanks.

Comment 2

[Tom Ritter [:tjr]]

Okay, yeah, I see now. After I close the tab, the count increments on about:protections - however the doorhanger reported that it blocked two fingerprinters, but about:protections only incremented by one. Is that intentional? From the copy on about:protections it seems like it's saying the number of trackers blocked, not the number of pages trackers were blocked on....

Comment 3

[Emma Zühlcke [:emz]]

For shims we set the replaced flag here: https://searchfox.org/mozilla-central/rev/31f5847a4494b3646edabbdd7ea39cb88509afe2/netwerk/url-classifier/UrlClassifierFeatureFingerprintingProtection.cpp#162
this may lead to us not correctly recording the fact that we still blocked a tracker. Could be that the method here doesn't pick it up anymore: https://searchfox.org/mozilla-central/rev/31f5847a4494b3646edabbdd7ea39cb88509afe2/toolkit/components/antitracking/TrackingDBService.sys.mjs#184

I'll look more into this. However it seems that this is rather a backlog item.

Comment 4

[Harshit Sohaney [:hsohaney]]

Attachment: Bug 1826418 - Added a new event to categorize replaced shims scripts for fingerprinting. Replaced shims for fingerprinting are counted in about:protections too now. r?timhuang

Comment 5

[Harshit Sohaney [:hsohaney]]

Attachment: Bug 1826418 - Added a new event to categorize replaced shims scripts for fingerprinting. Replaced shims for fingerprinting are counted in about:protections too now. r?timhuang

Comment 6

[Harshit Sohaney [:hsohaney]]

Attachment: Bug 1826418 - Part 2: Added a clause to check for replaced shims scripts when classifying for other event types. r?timhuang Differential Revision: https://phabricator.services.mozilla.com/D178324

Depends on D178324

Comment 7

[Harshit Sohaney [:hsohaney]]

Attachment: Bug 1826418 - Part 2: Added a clause to check for replaced shims scripts when classifying for other event types. r?timhuang

Depends on D178324

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/551ba6213443
Added a new event to categorize replaced shims scripts for fingerprinting. Replaced shims for fingerprinting are counted in about:protections too now. r=timhuang,anti-tracking-reviewers
https://hg.mozilla.org/integration/autoland/rev/af6b28cc40a8
Part 2: Added a clause to check for replaced shims scripts when classifying for other event types. r=timhuang

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/551ba6213443
https://hg.mozilla.org/mozilla-central/rev/af6b28cc40a8