Closed Bug 1826427 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 39376 - Rewrite test to avoid nested promise_test calls

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox114 fixed)

Status:
RESOLVED FIXED
Milestone:
114 Branch
Tracking Flags:
Tracking Status
firefox114 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 39376 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/39376
Details from upstream follow.

Chris Fredrickson <cfredric@chromium.org> wrote:

Rewrite test to avoid nested promise_test calls

This is an effort to make these tests as straightforward as possible,
to fix upstream flakiness. This CL removes the nested calls to
promise_test that occur in the iframe created by one of the top-level
tests, in favor of just running the iframe tests as top-level calls
to promise_test.

Bug: 1429782
Change-Id: I52e0368d2522e29afe1f2cb5822fac010756e254
Reviewed-on: https://chromium-review.googlesource.com/4397961
WPT-Export-Revision: 16c9ebc545ef3dfd6dc0b8e088617111d943f4c5

PR 39376 applied with additional changes from upstream: a544f9a82958c0db5ffcd4a8e476f137a3fda119, a5dc2e5f1c2b8afb5b6cef5a38269328f553ba10, f853785cb85b57e9c8af5dd1ce7c01d1ce9af60b

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 7 subtests

Status Summary

Firefox

OK : 1
FAIL: 7

Chrome

OK : 1
PASS: 7

Safari

OK : 1
FAIL: 7

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /top-level-storage-access-api/tentative/requestStorageAccessFor-insecure.sub.window.html [wpt.fyi]
    • [top-level-context] document.requestStorageAccessFor() should be supported on the document interface: FAIL (Chrome: PASS, Safari: FAIL)
    • [top-level-context] document.requestStorageAccessFor() should be rejected by default with no user gesture: FAIL (Chrome: PASS, Safari: FAIL)
    • [non-fully-active] document.requestStorageAccessFor() should not resolve when run in a detached frame: FAIL (Chrome: PASS, Safari: FAIL)
    • [non-fully-active] document.requestStorageAccessFor() should not resolve when run in a detached DOMParser document: FAIL (Chrome: PASS, Safari: FAIL)
    • [frame-on-insecure-page] document.requestStorageAccessFor() should be supported on the document interface in embedded iframes: FAIL (Chrome: PASS, Safari: FAIL)
    • [frame-on-insecure-page] document.requestStorageAccessFor() should be rejected when called in an iframe: FAIL (Chrome: PASS, Safari: FAIL)
    • [top-level-context] document.requestStorageAccessFor() should be rejected when called in an insecure context: FAIL (Chrome: PASS, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8bddbc74448c [wpt PR 39376] - Rewrite test to avoid nested promise_test calls, a=testonly https://hg.mozilla.org/integration/autoland/rev/5c97264c007a [wpt PR 39376] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/8bddbc74448c
https://hg.mozilla.org/mozilla-central/rev/5c97264c007a

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox114: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 114 Branch
You need to log in before you can comment on or make changes to this bug.