1826451 - Integrate Kyber (v3.02) from pq-crystals repository

Status: RESOLVED FIXED

(NSS :: Libraries, enhancement, P3)

Description

[John Schanck [:jschanck]]

We're adding the Kyber implementation from https://github.com/pq-crystals/kyber to NSS in Bug 1775046.

We should have a tool that automatically vendors this code for us.

Comment 1

[John Schanck [:jschanck]]

Attachment: Bug 1826451 - part 1: add a script for vendoring kyber from pq-crystals repo. r=rrelyea

Comment 2

[John Schanck [:jschanck]]

Attachment: Bug 1826451 - part 2: vendor github.com/pq-crystals/kyber/commit/e0d1c6ff. r=rrelyea

Comment 3

[BugBot [:suhaib / :marco]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:jschanck, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 4

[John Schanck [:jschanck]]

Attachment: WIP: Bug 1826451 - use NSS_SecureMemcmp and NSS_SecureSelect in Kyber.

Comment 5

[John Schanck [:jschanck]]

Updating the title here. The HACL* implementation being added in Bug 1866841 is going to track the NIST standard variant of Kyber (ML-KEM). We still want Kyber version 3.02 for TLS experiments.

Comment 6

[John Schanck [:jschanck]]

https://hg.mozilla.org/projects/nss/rev/c624680887cab4f20b317ef8d4ff7616d23132c7
https://hg.mozilla.org/projects/nss/rev/4b28ad830f68e62809571fc7b4da646256be51b5