1826466 - [Unified Search] Some icons are invisible when selected

Status: VERIFIED FIXED

(Firefox for Android :: Search, defect, P1)

Description

[Mike a [:mavduevskiy]]

Steps to reproduce

1. Set the app to the light theme.
2. With unified search enable, tap the search engine icon.
3. Select Bookmarks, Tabs or History icon in unified search.

Expected behavior

Icons are visible

Actual behavior

Icons are not visible

Device information

• Firefox version:
  113 Nightly
• Android device model:
  Pixel 7
• Android OS version:
  13

Any additional information?

Comment 1

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1826466 – fix unified search icons visibility (#1565)

Comment 2

[BMO Github Automation]

Authored by mike a
https://github.com/mozilla-mobile/firefox-android/commit/865b1d75f1376d043538882b6001863f7a22f980
[main] Bug 1826466 – fix unified search icons visibility

Comment 3

[Adina Petridean QA [:apetridean]]

Verified as fixed on Nightly 113.0a1 from 04/06 with Motorola Moto G9 plus (Android 11). Bookmarks, Tabs and History icons are visible.

Comment 4

[Adina Petridean QA [:apetridean]]

Attachment: search.mp4

Comment 5

[Chris Peterson [:cpeterson]]

Mike, can you please request uplift to 112? It's too late to fix for the 112.0 release, but we can include your fix in the 112.1 dot release.

Comment 6

[Mike a [:mavduevskiy]]

:cpeterson
Will do

Comment 7

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1826466 – fix unified search icons visibility (backport #1565) (#1582)

Comment 8

[Mike a [:mavduevskiy]]

Comment on attachment 9327468 [details] [review]
[mozilla-mobile/firefox-android] Bug 1826466 – fix unified search icons visibility (backport #1565) (#1582)

Beta/Release Uplift Approval Request

• User impact if declined: Application level Unified search icons (bookmarks, history and tabs) will be invisible when respected engines are selected in light theme.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The patch is simply applying a tint to a displayed icon.
• String changes made/needed: none
• Is Android affected?: Yes

Comment 9

[Dianna Smith [:diannaS]]

Comment on attachment 9327468 [details] [review]
[mozilla-mobile/firefox-android] Bug 1826466 – fix unified search icons visibility (backport #1565) (#1582)

Approved for 112.1.0 mobile dot release

Comment 10

[BMO Github Automation]

Authored by https://github.com/mergify[bot]
https://github.com/mozilla-mobile/firefox-android/commit/e1b48a65119bbeecc33fc72587e8ad5b6f8eea23
[releases_v112] Bug 1826466 – fix unified search icons visibility (#1582)

Comment 11

[Lorand Janos]

Verified as fixed on the latest RC 112.1.0 build.
The icons are visible.
Device used: Google Pixel 7 (Android 13).
Marking the ticket as verified.