Closed Bug 1826468 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 39381 - Revert "[GridNG] Subgrid gap initial support"

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox114 fixed)

RESOLVED FIXED
114 Branch
Tracking Status
firefox114 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 39381 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/39381
Details from upstream follow.

Jiewei Qian <qjw@chromium.org> wrote:

Revert "[GridNG] Subgrid gap initial support"

This reverts commit 8656d218b1c3e04a4358c9945157b9af8a70d0fe.

Reason for revert: Breaking WPT subgrid-item-block-size-001 on multiple bots

Sample:
https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/79031
https://ci.chromium.org/p/chromium/builders/ci/Mac12%20Tests/8171

Original change's description:

[GridNG] Subgrid gap initial support

This adds basic grid-gap support for subgrids according to the
algorithm described in the spec[1]. Some followup work will be required
for nested subgrids, orthogonal subgrids, and edge cases.

This also updates some of the existing grid test references to include
"Reference:" in the title.

[1] https://www.w3.org/TR/css-grid-2/#subgrid-item-contribution

Bug: 618969
Change-Id: I3851bde1c009910905bc70c7a853758616797200
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4383208
Reviewed-by: Ethan Jimenez \<ethavar@microsoft.com>
Commit-Queue: Alison Maher \<almaher@microsoft.com>
Reviewed-by: Ian Kilpatrick \<ikilpatrick@chromium.org>
Reviewed-by: Alison Maher \<almaher@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1126234}

Bug: 618969
Change-Id: Ie329e0c7b15a81839855e065fd5b59c6317f8392
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4401991
Auto-Submit: Jiewei Qian \<qjw@chromium.org>
Bot-Commit: Rubber Stamper \<rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Jiewei Qian \<qjw@chromium.org>
Commit-Queue: Jiewei Qian \<qjw@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1126337}

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1b5f1e14ec61 [wpt PR 39381] - Revert "[GridNG] Subgrid gap initial support", a=testonly
Test result changes from PR not available.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 114 Branch
You need to log in before you can comment on or make changes to this bug.