1826530 - Find a cleaner solution than manually running the CFRunLoop in DesktopCaptureImpl

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, task, P3)

Description

[Andreas Pehrson [:pehrsons]]

This is a followup to bug 1826483 which reinstated a CFRunLoopRunInMode that was removed in bug 1800213.

We should use an nsThread with a MessagePump that uses a CFRunLoop directly instead.

Comment 1

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1826530 - Break platform-dependent MessagePumps out to platform-specific files. r?ipc-reviewers

This makes things a bit clearer when adding the mac implementation.

Comment 2

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1826530 - Implement MessagePumpForNonMainUIThreads for mac. r?ipc-reviewers, r?xpcom-reviewers

The MessagePump implemented here is a MessagePumpCFRunLoopBase that also handles
xpcom events.

Comment 3

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1826530 - Switch the ScreenCapture thread on mac to a MessagePumpForNonMainUIThreads. r?webrtc-reviewers

Comment 4

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1826530 - From the Windows MessagePumpForNonMainUIThreads remove use of NSAutoReleasePool. r?ipc-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2534ba3f140f
Break platform-dependent MessagePumps out to platform-specific files. r=ipc-reviewers,nika
https://hg.mozilla.org/integration/autoland/rev/fe9e6fccc2e6
From the Windows MessagePumpForNonMainUIThreads remove use of NSAutoReleasePool. r=ipc-reviewers,nika
https://hg.mozilla.org/integration/autoland/rev/2174d8d45249
Implement MessagePumpForNonMainUIThreads for mac. r=xpcom-reviewers,ipc-reviewers,mstange,nika
https://hg.mozilla.org/integration/autoland/rev/027080336f71
Switch the ScreenCapture thread on mac to a MessagePumpForNonMainUIThreads. r=webrtc-reviewers,ng

Comment 6

[Noemi Erli[:noemi_erli]]

Backed out 4 changesets (Bug 1826530) for causing build bustages in MessagePump_android.cpp CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=RE0Sl2EtQNqdaKzjJqbsWg.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=027080336f71fd14439f6336f315427810391699

Log: https://treeherder.mozilla.org/logviewer?job_id=416680471&repo=autoland&lineNumber=19354

Backout: https://hg.mozilla.org/integration/autoland/rev/048238978f529aed3e06fb63ca63ab74b5992120

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8c48a98accbc
Break platform-dependent MessagePumps out to platform-specific files. r=ipc-reviewers,nika
https://hg.mozilla.org/integration/autoland/rev/6bc8a686c792
From the Windows MessagePumpForNonMainUIThreads remove use of NSAutoReleasePool. r=ipc-reviewers,nika
https://hg.mozilla.org/integration/autoland/rev/361fb27c3983
Implement MessagePumpForNonMainUIThreads for mac. r=xpcom-reviewers,ipc-reviewers,mstange,nika
https://hg.mozilla.org/integration/autoland/rev/5a6b4d0e8b83
Switch the ScreenCapture thread on mac to a MessagePumpForNonMainUIThreads. r=webrtc-reviewers,ng

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/8c48a98accbc
https://hg.mozilla.org/mozilla-central/rev/6bc8a686c792
https://hg.mozilla.org/mozilla-central/rev/361fb27c3983
https://hg.mozilla.org/mozilla-central/rev/5a6b4d0e8b83