1826551 - [wpt-sync] Sync PR 39391 - Nested calc() expressions need to consume all their tokens

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 39391 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/39391
Details from upstream follow.

Fredrik Söderquist <[e-mail]> wrote:

Nested calc() expressions need to consume all their tokens

When parsing a nested calc() expression that had a valid first part
(term) that was followed by an invalid operator the parsed part was
returned to the caller - which had already consumed the tokens within
the sub-expression. The caller only checked that an expression node was
returned, which meant that the sub-expression was considered valid.

Require that all tokens that are part of the sub-expression have been
consumed after parsing has completed to fail the parsing in such a case.

Fixed: 1430413
Change-Id: I3072e22e2a7b81296510173266814a18fb6bfc37

Reviewed-on: https://chromium-review.googlesource.com/4400956
WPT-Export-Revision: 37971085c2460e202bbf49c646fd48b58d6c63f4

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=a1d09283733bf99fd1fb9712ffff659be9c19c7c

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/73e55bc14ef6
[wpt PR 39391] - Nested calc() expressions need to consume all their tokens, a=testonly

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/73e55bc14ef6