Closed Bug 1826573 Opened 2 years ago Closed 9 months ago

Implement duplicate named capture groups

Categories

(Core :: JavaScript Engine, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
128 Branch
Tracking Status
firefox128 --- fixed

People

(Reporter: dminor, Assigned: dminor)

References

(Blocks 1 open bug)

Details

(Keywords: parity-chrome, parity-safari)

Attachments

(3 files, 1 obsolete file)

Duplicate named capture groups for regex is in stage 3, we should implement it.

Severity: -- → N/A
Priority: -- → P2
Status: NEW → ASSIGNED

We'll wait until the irregexp support is completed upstream, then wire this up in SpiderMonkey.

Status: ASSIGNED → NEW

Iain has an update for a version of irregexp that contains the upstream changes in Bug 1879225.

Status: NEW → ASSIGNED
Depends on: 1879225

The update in Bug 1882696 has the upstream changes, Bug 1879225 wasn't quite recent enough.

Depends on: 1882696
No longer depends on: 1879225

Depends on D209744

Depends on D209745

Attachment #9400583 - Attachment description: WIP: Bug 1826573 - Support duplicate named capture groups → Bug 1826573 - Support duplicate named capture groups; r=iain!
Pushed by dminor@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e432aff3b388 Add pref for duplicate named capture groups; r=iain https://hg.mozilla.org/integration/autoland/rev/c15e54651ba1 Enable test262 tests; r=iain https://hg.mozilla.org/integration/autoland/rev/7dfa6ee8a288 Support duplicate named capture groups; r=iain
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → 128 Branch

Comment on attachment 9406193 [details]
Bug 1826573 - Add pref for duplicate named capture groups. r=#spidermonkey-reviewers,dminor!

Revision D212971 was moved to bug 1899813. Setting attachment 9406193 [details] to obsolete.

Attachment #9406193 - Attachment is obsolete: true
Attachment #9406193 - Attachment description: Bug 1826573 - Add pref for duplicate named capture groups. r=#spidermonkey-reviewers,iain! → Bug 1826573 - Add pref for duplicate named capture groups. r=#spidermonkey-reviewers,dminor!
Attachment #9406193 - Attachment is obsolete: false

Comment on attachment 9406193 [details]
Bug 1826573 - Add pref for duplicate named capture groups. r=#spidermonkey-reviewers,dminor!

Revision D212971 was moved to bug 1899813. Setting attachment 9406193 [details] to obsolete.

Attachment #9406193 - Attachment is obsolete: true
Blocks: 1903288
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: