1826591 - Log crashes in the ExceptionHandler if logging uncaughtExceptions cause a crash

Status: RESOLVED FIXED

(Fenix :: General, task, P1)

Description

[Jonathan Almeida [:jonalmeida]]

As an extension to bug 1826590, we should catch any exceptions thrown when the crash reporter crashes and, at the minimum, log it to the console as an error.

Something as simple as adding a catch block would suffice:

try {
    crashReporter.onCrash()
} catch (e: Exception) {
    Log.e(TAG, "Crash reporter crashed.", e)
} finally {
    terminateProcess()
}

Comment 1

[Jonathan Almeida [:jonalmeida]]

I lost track of this task in 113 - fixing it now.

Comment 2

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1826591 - Catch and log exceptions when reporting crashes (#1978)

Comment 3

[BMO Github Automation]

Authored by https://github.com/jonalmeida
https://github.com/mozilla-mobile/firefox-android/commit/6c77bcdf8dad4f950f6f2e3a5c7ab08070ab98bb
[main] Bug 1826591 - Catch and log exceptions when reporting crashes

Comment 4

[Adina Petridean QA [:apetridean]]

Hello Jonathan,

Is QA verification needed for this issue? If so, could you please provide us with some steps to reproduce (STR) or testing scenarios?

Thank you!

Comment 5

[Jonathan Almeida [:jonalmeida]]

Clearing qe-verify since there is nothing to verify. Thanks Adina!