1826795 - Find a way to notify user of non tab process crashing (crash) or update required

Status: RESOLVED WONTFIX

(Toolkit :: Crash Reporting, defect)

Description

[:gerard-majax]

Right now we would show only about:tabcrashed or about:restartrequired if the user is attempting to create a new tab process. People might get into inconsistent state for some time if it is another kind that is failing for either those reasons.

Comment 1

[:gerard-majax]

Attachment: WIP: Bug 1826795 - Remove leftover PluginCrashReporter

Comment 2

[:gerard-majax]

Attachment: WIP: Bug 1826795 - Show unsubmitted crash notification for non content crashes

Depends on D175858

Comment 3

[:gerard-majax]

(In reply to Alexandre LISSY :gerard-majax from comment #2)

Created attachment 9329222 [details]
WIP: Bug 1826795 - Show unsubmitted crash notification for non content crashes

Depends on D175858

So is in fact useless? We have https://searchfox.org/mozilla-central/rev/31f5847a4494b3646edabbdd7ea39cb88509afe2/browser/components/BrowserGlue.sys.mjs#2256 that will do the work. There's a 10 minutes timeout before checking the unsubmitted crashes, but locally on a mach run I can see it works well on pending utility crashes.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:jld, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 5

[Nika Layzell [:nika] (ni? for response)]

This isn't quite IPC-specific, and is moreso a frontend/crash reporting decision. Moving to Toolkit :: Crash Reporting for now, but can be redirected to a more appropriate component.

Comment 6

[:gerard-majax]

(In reply to Alexandre LISSY :gerard-majax from comment #3)

(In reply to Alexandre LISSY :gerard-majax from comment #2)

Created attachment 9329222 [details]
WIP: Bug 1826795 - Show unsubmitted crash notification for non content crashes

Depends on D175858

So is in fact useless? We have https://searchfox.org/mozilla-central/rev/31f5847a4494b3646edabbdd7ea39cb88509afe2/browser/components/BrowserGlue.sys.mjs#2256 that will do the work. There's a 10 minutes timeout before checking the unsubmitted crashes, but locally on a mach run I can see it works well on pending utility crashes.

So it looks like there's mostly nothing we need to do for the case of non content process crashing, we already have the infrastructure, and it all depends on the enabling of unsubmitted crash checks at https://searchfox.org/mozilla-central/rev/f32d5f3949a3f4f185122142b29f2e3ab776836e/browser/app/profile/firefox.js#2253-2260. I understand from a product perspective we might not want to enable that by default, but then we would need a way to collect those reports somehow.

The second part of handling those errors is about a non-content process crashing due to about:restartrequired. After checking deeper, I believe in such a case the user would experience some issues (sound breaking, etc.) and quickly about:restartrequired should come into the play. I am unsure there is much we can do here that would not require extensive changes for a low added value.

Comment 7

[Phabricator Automation]

Comment on attachment 9329221 [details]
WIP: Bug 1826795 - Remove leftover PluginCrashReporter

Revision D175858 was moved to bug 1830251. Setting attachment 9329221 [details] to obsolete.