Closed
Bug 1826805
Opened 2 years ago
Closed 2 years ago
[wpt-sync] Sync PR 39409 - Fix quote style in generated filters WPT test.
Categories
(Core :: DOM: Core & HTML, task, P4)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
114 Branch
| Tracking | Status | |
|---|---|---|
| firefox114 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
(Blocks 1 open bug, )
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 39409 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/39409
Details from upstream follow.
Jean-Philippe Gravel <jpgravel@chromium.org> wrote:
Fix quote style in generated filters WPT test.
The style guide recommends using single quotes in JavaScript and double quotes in HTML:
https://chromium.googlesource.com/chromium/src/+/main/styleguide/web/web.mdChange-Id: Iec6d47c301457ea5e9a6bf0c0219a80da53efbf5
Bug: 1428652
Reviewed-on: https://chromium-review.googlesource.com/4400839
WPT-Export-Revision: a121bde637e99d19fa4f566bc23b7cf654753b0a
|
Assignee | |
Comment 1•2 years ago
|
||
PR 39409 applied with additional changes from upstream: 8b9f4e275162d151dc2a0c847601542d75051cbf, 35f6bf623496fda2d7146162b5e9c472ea952110, 97908a14c0ba125be6d284b30ccb7f822e830525, ffb8ba309db11dd11cce255bb66ddf95586d99bb
|
|
Assignee | |
Updated•2 years ago
|
Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core
|
|
Assignee | |
Comment 2•2 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d12a0d8eb06ca800488a661f30a1919a0f54e6b
|
|
Assignee | |
Comment 3•2 years ago
|
||
CI Results
Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 33 tests
Status Summary
Firefox
OK : 20
FAIL : 22
TIMEOUT: 11
ERROR : 10
Chrome
OK : 30
PASS : 30
FAIL : 3
Safari
OK : 20
FAIL : 22
TIMEOUT: 11
ERROR : 10
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
- /html/canvas/element/filters/2d.filter.canvasFilterObject.blur.exceptions.tentative.html [wpt.fyi]
- Test exceptions on CanvasFilter() blur.object:
FAIL(Chrome:PASS, Safari:FAIL)
- Test exceptions on CanvasFilter() blur.object:
- /html/canvas/element/filters/2d.filter.canvasFilterObject.colorMatrix.tentative.html [wpt.fyi]
- Test the functionality of ColorMatrix filters in CanvasFilter objects:
FAIL(Chrome:PASS, Safari:FAIL)
- Test the functionality of ColorMatrix filters in CanvasFilter objects:
- /html/canvas/element/filters/2d.filter.canvasFilterObject.componentTransfer.discrete.tentative.html [wpt.fyi]
- Test pixels on CanvasFilter() componentTransfer with discrete type:
FAIL(Chrome:PASS, Safari:FAIL)
- Test pixels on CanvasFilter() componentTransfer with discrete type:
- /html/canvas/element/filters/2d.filter.canvasFilterObject.componentTransfer.gamma.tentative.html [wpt.fyi]
- Test pixels on CanvasFilter() componentTransfer with gamma type:
FAIL(Chrome:PASS, Safari:FAIL)
- Test pixels on CanvasFilter() componentTransfer with gamma type:
- /html/canvas/element/filters/2d.filter.canvasFilterObject.componentTransfer.identity.tentative.html [wpt.fyi]
- Test pixels on CanvasFilter() componentTransfer with identity type:
FAIL(Chrome:PASS, Safari:FAIL)
- Test pixels on CanvasFilter() componentTransfer with identity type:
- /html/canvas/element/filters/2d.filter.canvasFilterObject.componentTransfer.linear.tentative.html [wpt.fyi]
- Test pixels on CanvasFilter() componentTransfer with linear type:
FAIL(Chrome:PASS, Safari:FAIL)
- Test pixels on CanvasFilter() componentTransfer with linear type:
- /html/canvas/element/filters/2d.filter.canvasFilterObject.componentTransfer.table.tentative.html [wpt.fyi]
- Test pixels on CanvasFilter() componentTransfer with table type:
FAIL(Chrome:PASS, Safari:FAIL)
- Test pixels on CanvasFilter() componentTransfer with table type:
- /html/canvas/element/filters/2d.filter.canvasFilterObject.convolveMatrix.exceptions.tentative.html [wpt.fyi]
- Test exceptions on CanvasFilter() convolveMatrix:
FAIL(Chrome:PASS, Safari:FAIL)
- Test exceptions on CanvasFilter() convolveMatrix:
- /html/canvas/element/filters/2d.filter.canvasFilterObject.tentative.html [wpt.fyi]
- Test CanvasFilter() object:
FAIL(Chrome:PASS, Safari:FAIL)
- Test CanvasFilter() object:
- /html/canvas/element/filters/2d.filter.canvasFilterObject.turbulence.inputTypes.tentative.html [wpt.fyi]
- Test exceptions on CanvasFilter() turbulence object:
FAIL(Chrome:PASS, Safari:FAIL)
- Test exceptions on CanvasFilter() turbulence object:
- /html/canvas/offscreen/filters/2d.filter.canvasFilterObject.blur.exceptions.tentative.html [wpt.fyi]:
ERROR(Chrome:OK, Safari:ERROR)- Test exceptions on CanvasFilter() blur.object:
TIMEOUT(Chrome:PASS, Safari:TIMEOUT)
- Test exceptions on CanvasFilter() blur.object:
- /html/canvas/offscreen/filters/2d.filter.canvasFilterObject.blur.exceptions.tentative.worker.html [wpt.fyi]
- Test exceptions on CanvasFilter() blur.object:
FAIL(Chrome:PASS, Safari:FAIL)
- Test exceptions on CanvasFilter() blur.object:
- /html/canvas/offscreen/filters/2d.filter.canvasFilterObject.colorMatrix.tentative.html [wpt.fyi]:
ERROR(Chrome:OK, Safari:ERROR)- Test the functionality of ColorMatrix filters in CanvasFilter objects:
TIMEOUT(Chrome:PASS, Safari:TIMEOUT)
- Test the functionality of ColorMatrix filters in CanvasFilter objects:
- /html/canvas/offscreen/filters/2d.filter.canvasFilterObject.colorMatrix.tentative.worker.html [wpt.fyi]
- Test the functionality of ColorMatrix filters in CanvasFilter objects:
FAIL(Chrome:PASS, Safari:FAIL)
- Test the functionality of ColorMatrix filters in CanvasFilter objects:
- /html/canvas/offscreen/filters/2d.filter.canvasFilterObject.componentTransfer.discrete.tentative.html [wpt.fyi]:
ERROR(Chrome:OK, Safari:ERROR)- Test pixels on CanvasFilter() componentTransfer with discrete type:
TIMEOUT(Chrome:PASS, Safari:TIMEOUT)
- Test pixels on CanvasFilter() componentTransfer with discrete type:
- /html/canvas/offscreen/filters/2d.filter.canvasFilterObject.componentTransfer.discrete.tentative.worker.html [wpt.fyi]
- Test pixels on CanvasFilter() componentTransfer with discrete type:
FAIL(Chrome:PASS, Safari:FAIL)
- Test pixels on CanvasFilter() componentTransfer with discrete type:
- /html/canvas/offscreen/filters/2d.filter.canvasFilterObject.componentTransfer.gamma.tentative.html [wpt.fyi]:
ERROR(Chrome:OK, Safari:ERROR)- Test pixels on CanvasFilter() componentTransfer with gamma type:
TIMEOUT(Chrome:PASS, Safari:TIMEOUT)
- Test pixels on CanvasFilter() componentTransfer with gamma type:
- /html/canvas/offscreen/filters/2d.filter.canvasFilterObject.componentTransfer.gamma.tentative.worker.html [wpt.fyi]
- Test pixels on CanvasFilter() componentTransfer with gamma type:
FAIL(Chrome:PASS, Safari:FAIL)
- Test pixels on CanvasFilter() componentTransfer with gamma type:
- /html/canvas/offscreen/filters/2d.filter.canvasFilterObject.componentTransfer.identity.tentative.html [wpt.fyi]:
ERROR(Chrome:OK, Safari:ERROR)- Test pixels on CanvasFilter() componentTransfer with identity type:
TIMEOUT(Chrome:PASS, Safari:TIMEOUT)
- Test pixels on CanvasFilter() componentTransfer with identity type:
- /html/canvas/offscreen/filters/2d.filter.canvasFilterObject.componentTransfer.identity.tentative.worker.html [wpt.fyi]
- Test pixels on CanvasFilter() componentTransfer with identity type:
FAIL(Chrome:PASS, Safari:FAIL)
- Test pixels on CanvasFilter() componentTransfer with identity type:
- /html/canvas/offscreen/filters/2d.filter.canvasFilterObject.componentTransfer.linear.tentative.html [wpt.fyi]:
ERROR(Chrome:OK, Safari:ERROR)- Test pixels on CanvasFilter() componentTransfer with linear type:
TIMEOUT(Chrome:PASS, Safari:TIMEOUT)
- Test pixels on CanvasFilter() componentTransfer with linear type:
- /html/canvas/offscreen/filters/2d.filter.canvasFilterObject.componentTransfer.linear.tentative.worker.html [wpt.fyi]
- Test pixels on CanvasFilter() componentTransfer with linear type:
FAIL(Chrome:PASS, Safari:FAIL)
- Test pixels on CanvasFilter() componentTransfer with linear type:
- /html/canvas/offscreen/filters/2d.filter.canvasFilterObject.componentTransfer.table.tentative.html [wpt.fyi]:
ERROR(Chrome:OK, Safari:ERROR)- Test pixels on CanvasFilter() componentTransfer with table type:
TIMEOUT(Chrome:PASS, Safari:TIMEOUT)
- Test pixels on CanvasFilter() componentTransfer with table type:
- /html/canvas/offscreen/filters/2d.filter.canvasFilterObject.componentTransfer.table.tentative.worker.html [wpt.fyi]
- Test pixels on CanvasFilter() componentTransfer with table type:
FAIL(Chrome:PASS, Safari:FAIL)
- Test pixels on CanvasFilter() componentTransfer with table type:
- /html/canvas/offscreen/filters/2d.filter.canvasFilterObject.convolveMatrix.exceptions.tentative.html [wpt.fyi]:
ERROR(Chrome:OK, Safari:ERROR)- Test exceptions on CanvasFilter() convolveMatrix:
TIMEOUT(Chrome:PASS, Safari:TIMEOUT)
- Test exceptions on CanvasFilter() convolveMatrix:
- /html/canvas/offscreen/filters/2d.filter.canvasFilterObject.convolveMatrix.exceptions.tentative.worker.html [wpt.fyi]
- Test exceptions on CanvasFilter() convolveMatrix:
FAIL(Chrome:PASS, Safari:FAIL)
- Test exceptions on CanvasFilter() convolveMatrix:
- /html/canvas/offscreen/filters/2d.filter.canvasFilterObject.tentative.html [wpt.fyi]:
ERROR(Chrome:OK, Safari:ERROR)- Test CanvasFilter() object:
TIMEOUT(Chrome:PASS, Safari:TIMEOUT)
- Test CanvasFilter() object:
- /html/canvas/offscreen/filters/2d.filter.canvasFilterObject.tentative.worker.html [wpt.fyi]
- Test CanvasFilter() object:
FAIL(Chrome:PASS, Safari:FAIL)
- Test CanvasFilter() object:
- /html/canvas/offscreen/filters/2d.filter.canvasFilterObject.turbulence.inputTypes.tentative.html [wpt.fyi]:
ERROR(Chrome:OK, Safari:ERROR)- Test exceptions on CanvasFilter() turbulence object:
TIMEOUT(Chrome:PASS, Safari:TIMEOUT)
- Test exceptions on CanvasFilter() turbulence object:
- /html/canvas/offscreen/filters/2d.filter.canvasFilterObject.turbulence.inputTypes.tentative.worker.html [wpt.fyi]
- Test exceptions on CanvasFilter() turbulence object:
FAIL(Chrome:PASS, Safari:FAIL)
- Test exceptions on CanvasFilter() turbulence object:
- /html/canvas/element/filters/2d.filter.canvasFilterObject.dropShadow.tentative.html [wpt.fyi]:
FAIL(Chrome:FAIL, Safari:FAIL) - /html/canvas/offscreen/filters/2d.filter.canvasFilterObject.dropShadow.tentative.html [wpt.fyi]:
FAIL(Chrome:FAIL, Safari:FAIL) - /html/canvas/offscreen/filters/2d.filter.canvasFilterObject.dropShadow.tentative.w.html [wpt.fyi]:
TIMEOUT(Chrome:FAIL, Safari:TIMEOUT)
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c32575d20b24
[wpt PR 39409] - Fix quote style in generated WPT filter tests., a=testonly
|
||
Comment 5•2 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox114:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 114 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•