Closed Bug 1826811 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 39410 - TaskSignal: add test for dependents added during prioritychange

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox114 fixed)

Status:
RESOLVED FIXED
Milestone:
114 Branch
Tracking Flags:
Tracking Status
firefox114 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 39410 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/39410
Details from upstream follow.

Scott Haseley <shaseley@chromium.org> wrote:

TaskSignal: add test for dependents added during prioritychange

Dependent signals can be added during prioritychange events, e.g. by
calling TaskSignal.any([], {priority: signal}) during signal's
prioritychange event. Signaling prioritychange already has an early-
out that covers this case (if changing to the same priority, do
nothing), which is the intended behavior. This CL adds test coverage and
removes the associated TODO.

Bug: 1323391
Change-Id: I332d6ac4ff86e9145dd66c594803fe3f1b8b1c93
Reviewed-on: https://chromium-review.googlesource.com/4405036
WPT-Export-Revision: 7e1cc15067dac06c181cf1a3e3d2a16f384bb739

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests and 11 subtests

Status Summary

Firefox

OK : 4
FAIL: 44

Chrome

OK : 4
PASS: 44

Safari

OK : 4
FAIL: 44

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /scheduler/task-signal-any-priority.tentative.any.worker.html [wpt.fyi]
    • TaskSignal.any() returns a user-visible TaskSignal when no priority is specified: FAIL (Chrome: PASS, Safari: FAIL)
    • TaskSignal.any() returns a signal with the correct priority when intialized with a string: FAIL (Chrome: PASS, Safari: FAIL)
    • TaskSignal.any() returns a signal with the correct priority when intialized with a TaskSignal: FAIL (Chrome: PASS, Safari: FAIL)
    • TaskSignal.any() returns a signal with dynamic priority: FAIL (Chrome: PASS, Safari: FAIL)
    • Priority change events fire for composite signals: FAIL (Chrome: PASS, Safari: FAIL)
    • Priority change events fire for composite signals with intermediate sources: FAIL (Chrome: PASS, Safari: FAIL)
    • Priority change propagates to multiple dependent signals in the right order: FAIL (Chrome: PASS, Safari: FAIL)
    • TaskSignal.any() does not propagate abort when not given dependent abort signals: FAIL (Chrome: PASS, Safari: FAIL)
    • TaskSignal.any() propagates abort and priority: FAIL (Chrome: PASS, Safari: FAIL)
    • TaskSignal.any() propagates priority after returning an aborted signal: FAIL (Chrome: PASS, Safari: FAIL)
    • TaskSignal.any() does not fire prioritychange for dependents added during prioritychange: FAIL (Chrome: PASS, Safari: FAIL)
  • /scheduler/task-signal-any-priority.tentative.any.html [wpt.fyi]
    • TaskSignal.any() returns a user-visible TaskSignal when no priority is specified: FAIL (Chrome: PASS, Safari: FAIL)
    • TaskSignal.any() returns a signal with the correct priority when intialized with a string: FAIL (Chrome: PASS, Safari: FAIL)
    • TaskSignal.any() returns a signal with the correct priority when intialized with a TaskSignal: FAIL (Chrome: PASS, Safari: FAIL)
    • TaskSignal.any() returns a signal with dynamic priority: FAIL (Chrome: PASS, Safari: FAIL)
    • Priority change events fire for composite signals: FAIL (Chrome: PASS, Safari: FAIL)
    • Priority change events fire for composite signals with intermediate sources: FAIL (Chrome: PASS, Safari: FAIL)
    • Priority change propagates to multiple dependent signals in the right order: FAIL (Chrome: PASS, Safari: FAIL)
    • TaskSignal.any() does not propagate abort when not given dependent abort signals: FAIL (Chrome: PASS, Safari: FAIL)
    • TaskSignal.any() propagates abort and priority: FAIL (Chrome: PASS, Safari: FAIL)
    • TaskSignal.any() propagates priority after returning an aborted signal: FAIL (Chrome: PASS, Safari: FAIL)
    • TaskSignal.any() does not fire prioritychange for dependents added during prioritychange: FAIL (Chrome: PASS, Safari: FAIL)
  • /scheduler/task-signal-any-priority.tentative.any.serviceworker.html [wpt.fyi]
    • TaskSignal.any() returns a user-visible TaskSignal when no priority is specified: FAIL (Chrome: PASS, Safari: FAIL)
    • TaskSignal.any() returns a signal with the correct priority when intialized with a string: FAIL (Chrome: PASS, Safari: FAIL)
    • TaskSignal.any() returns a signal with the correct priority when intialized with a TaskSignal: FAIL (Chrome: PASS, Safari: FAIL)
    • TaskSignal.any() returns a signal with dynamic priority: FAIL (Chrome: PASS, Safari: FAIL)
    • Priority change events fire for composite signals: FAIL (Chrome: PASS, Safari: FAIL)
    • Priority change events fire for composite signals with intermediate sources: FAIL (Chrome: PASS, Safari: FAIL)
    • Priority change propagates to multiple dependent signals in the right order: FAIL (Chrome: PASS, Safari: FAIL)
    • TaskSignal.any() does not propagate abort when not given dependent abort signals: FAIL (Chrome: PASS, Safari: FAIL)
    • TaskSignal.any() propagates abort and priority: FAIL (Chrome: PASS, Safari: FAIL)
    • TaskSignal.any() propagates priority after returning an aborted signal: FAIL (Chrome: PASS, Safari: FAIL)
    • TaskSignal.any() does not fire prioritychange for dependents added during prioritychange: FAIL (Chrome: PASS, Safari: FAIL)
  • /scheduler/task-signal-any-priority.tentative.any.sharedworker.html [wpt.fyi]
    • TaskSignal.any() returns a user-visible TaskSignal when no priority is specified: FAIL (Chrome: PASS, Safari: FAIL)
    • TaskSignal.any() returns a signal with the correct priority when intialized with a string: FAIL (Chrome: PASS, Safari: FAIL)
    • TaskSignal.any() returns a signal with the correct priority when intialized with a TaskSignal: FAIL (Chrome: PASS, Safari: FAIL)
    • TaskSignal.any() returns a signal with dynamic priority: FAIL (Chrome: PASS, Safari: FAIL)
    • Priority change events fire for composite signals: FAIL (Chrome: PASS, Safari: FAIL)
    • Priority change events fire for composite signals with intermediate sources: FAIL (Chrome: PASS, Safari: FAIL)
    • Priority change propagates to multiple dependent signals in the right order: FAIL (Chrome: PASS, Safari: FAIL)
    • TaskSignal.any() does not propagate abort when not given dependent abort signals: FAIL (Chrome: PASS, Safari: FAIL)
    • TaskSignal.any() propagates abort and priority: FAIL (Chrome: PASS, Safari: FAIL)
    • TaskSignal.any() propagates priority after returning an aborted signal: FAIL (Chrome: PASS, Safari: FAIL)
    • TaskSignal.any() does not fire prioritychange for dependents added during prioritychange: FAIL (Chrome: PASS, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/77ca35fde6da [wpt PR 39410] - TaskSignal: add test for dependents added during prioritychange, a=testonly https://hg.mozilla.org/integration/autoland/rev/108ddcb60244 [wpt PR 39410] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/77ca35fde6da
https://hg.mozilla.org/mozilla-central/rev/108ddcb60244

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox114: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 114 Branch
You need to log in before you can comment on or make changes to this bug.