Closed Bug 1826846 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 39416 - [wpt-lint] Handle `FileNotFoundError` when `git` is not found

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox114 fixed)

RESOLVED FIXED
114 Branch
Tracking Status
firefox114 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 39416 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/39416
Details from upstream follow.

Jonathan Lee <jonathanjlee@google.com> wrote:

[wpt-lint] Handle FileNotFoundError when git is not found

tools.lint.lint is unimportable when git does not exist in the PATH:

  ...
  File "C:\b\s\w\ir\third_party\wpt_tools\wpt\tools\lint\__init__.py", line 1, in <module>
    from . import lint  # noqa: F401
  File "C:\b\s\w\ir\third_party\wpt_tools\wpt\tools\lint\lint.py", line 1135, in <module>
    subprocess.check_output(["git", "--version"])
  ...
  File "C:\b\s\w\ir\.task_template_vpython_cache\vpython\store\cpython-e6tenrlsesftvg6k08ajgkk7b4\contents\bin\Lib\subprocess.py", line 1311, in _execute_child
    hp, ht, pid, tid = _winapi.CreateProcess(executable, args,
FileNotFoundError: [WinError 2] The system cannot find the file specified
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/59531e86d742 [wpt PR 39416] - [wpt-lint] Handle `FileNotFoundError` when `git` is not found, a=testonly
Test result changes from PR not available.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 114 Branch
You need to log in before you can comment on or make changes to this bug.