1826848 - [CtW] Assert cache is disabled before calling sync IPDL calls

Status: RESOLVED WONTFIX

(Core :: Disability Access APIs, defect)

Description

[Eitan Isaacson [:eeejay]]

There are several methods in RemoteAccessible that should never be called when caching is enabled. We need to assert the state of the pref in those functions.

Comment 1

[Eitan Isaacson [:eeejay]]

A list of such methods:

• NativeState
• Relations
• SelectionBoundsAt
• TableOfACell
• GetColRowExtents
• GetPosition
• ColExtent
• TableCaption
• TableSummary
• TableColumnCount
• TableRowCount
• TableCellAt
• TableCellIndexAt
• TableColumnIndexAt
• TableRowIndexAt
• TableRowAndColumnIndicesAt
• TableColumnExtentAt
• TableRowExtentAt
• TableColumnDescription
• TableRowDescription
• TableColumnSelected
• TableRowSelected
• TableCellSelected
• TableSelectedCellCount
• TableSelectedColumnCount
• TableSelectedRowCount
• TableSelectedCells
• TableSelectedCellIndices
• TableSelectedColumnIndices
• TableSelectedRowIndices
• TableSelectColumn
• TableSelectRow
• TableUnselectColumn
• TableUnselectRow
• AtkTableColumnHeader
• AtkTableRowHeader
• AtkKeyBinding

Comment 2

[Eitan Isaacson [:eeejay]]

SelectionBoundsAt too

Comment 3

[Eitan Isaacson [:eeejay]]

Extents as well.

Comment 4

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1826848 - Fix ATK extents to used cached bounds. r?morgan

Comment 5

[James Teh [:Jamie] (away returning 14 Apr)]

Assertions are also needed for ColIdx, RowIdx, RowExtent, ColHeaderCells, RowHeaderCells, IsCellSelected.

Comment 6

[Phabricator Automation]

Comment on attachment 9328050 [details]
Bug 1826848 - Fix ATK extents to used cached bounds. r?morgan

Revision D175187 was moved to bug 1826870. Setting attachment 9328050 [details] to obsolete.

Comment 7

[James Teh [:Jamie] (away returning 14 Apr)]

Superseded by bug 1821957, where I remove all these methods completely. :)