1826853 - [CtW][tail-end] Sync call RemoteAccessible::CaretLineNumber() is still used in MacOS

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Eitan Isaacson [:eeejay]]

A non sync or cache alternative should be used.

Comment 1

[James Teh [:Jamie] (away returning 28 Jan)]

When does VoiceOver actually use this? It seems we've never implemented this correctly. Due to a typo, RemoteAccessible::CaretLineNumber actually gets the caret offset! Furthermore, I couldn't find any way to get the current line number with VO, even in Safari.

Comment 2

[Eitan Isaacson [:eeejay]]

This obviously doesn't work. I do see this implemented in WK and Blink. I think this can be done with the cached selection and line boundaries. I'll take this.

Comment 3

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1826853 - Add a caching version of CaretLineNumber and fix sync version. r?Jamie!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/28c49102780c
Add a caching version of CaretLineNumber and fix sync version. r=Jamie

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/28c49102780c

Comment 6

[James Teh [:Jamie] (away returning 28 Jan)]

Comment on attachment 9331651 [details]
Bug 1826853 - Add a caching version of CaretLineNumber and fix sync version. r?Jamie!

Beta/Release Uplift Approval Request

• User impact if declined: Incorrect caret line number reported by Mac a11y tools. Also needed to uplift bug 1830466.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Only affects a11y exposure of caret line number. Covered by automated tests.
• String changes made/needed:
• Is Android affected?: No

Comment 7

[Pascal Chevrel:pascalc]

Comment on attachment 9331651 [details]
Bug 1826853 - Add a caching version of CaretLineNumber and fix sync version. r?Jamie!

Approved for 114 beta 5, thanks.

Comment 8

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/440c4a48614a