Open Bug 1826918 Opened 1 year ago Updated 1 year ago

Make array of content nodes initializers split from its users

Categories

(Core :: DOM: Editor, task)

task

Tracking

()

People

(Reporter: masayuki, Unassigned)

References

(Blocks 1 open bug)

Details

In a lot of places, HTMLEditor does:

AutoTArray<OwningNonNull<nsIContent>, N> arrayOfContents;
{
  arrayOfContents.AppendElement(...);
}
for (const OwningNonNull<nsIContent>& content : arrayOfContents) {
  can_run_script(MOZ_KnownLive(content));
}

If the first block is big, it's unclear that what it does and it's hard to write the main handling code without MOZ_KnownLive. Therefore, the first block should be split from the method.

You need to log in before you can comment on or make changes to this bug.